Repository navigation
plugin/router: leave external links to the browser - #75
Merged
Merged
Conversation
x-router:link intercepted every click and navigated to the link's path, ignoring where the link leads. A link to another origin opened the same path within the application, and "mailto:" and "tel:" links navigated to their address or number as a path. $active compared only the path as well, so an external link to "/" was active on the home page. Treat a link whose protocol or host differs from the page's as external: the click handler leaves it to the browser, and $active is false for it. The origin is not compared, since browsers report it differently for file: URLs.
📦 Bundle size comparison
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x-router:linkintercepted every click and navigated to the link's path, ignoring where the link leads: a link to another origin opened the same path within the application, andmailto:andtel:links navigated to their address or number as a path.$activecompared only the path as well, so an external link to/was active on the home page.Links whose protocol or host differs from the page's are now left to the browser, and
$activeis false for them.