Detect the macos.binary.arm64 package type used by R-devel 4.7 on macOS - #144
Merged
Merged
Conversation
Member
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R-devel (4.7.0) on macOS arm64 reports
.Platform$pkgTypeasmacos.binary.arm64, whose<system>ismacos, not themacosxthatpkg_type_system_for_os()returns for darwin.current_r_custom_pkg_type()compared the two withidentical(), so it dropped the type from the platform name and pkgcache looked for binaries inbin/macosx/sonoma-arm64/contrib/4.7. CRAN has moved those tobin/macos/arm64/contrib/4.7and the old directory no longer has a 4.7 subdirectory, so metadata and downloads 404.Fixed by treating
macosas a valid package-type system on darwin, alongsidemacosx. pkgcache then keeps the type in the platform name and derivesbin/macos/arm64/contrib/<x.y>from it.(For the records, related to r-lib/pak#909.)