Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd2e36481a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| static INDEXING_OPERATION_DURATION_SECONDS: LazyHistogram = lazy_histogram!( | ||
| name: "operation_duration_seconds", | ||
| description: "Elapsed seconds for indexing operations, by owning actor and operation", | ||
| subsystem: "indexing", |
There was a problem hiding this comment.
Once these statics are exercised they expose quickwit_indexing_operation_duration_seconds and quickwit_actor_duration_seconds on the public /metrics endpoint, but docs/reference/metrics.md:28-41 neither has an actor section nor lists the new indexing histogram. Operators who use that catalog cannot discover the labels or the important overlap/cancellation semantics, so add both entries (and those semantics) to the metrics reference.
AGENTS.md reference: AGENTS.md:L23-L24
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.