Skip to content

test(qwp): fix port collision flake in walk tracker test #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bluestreak01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(qwp): fix port collision flake in walk tracker test #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...rc/test/java/io/questdb/client/test/cutlass/qwp/client/QwpQueryClientWalkTrackerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,10 +441,15 @@ public void testWalk_TransportFailureContinuesWalk() throws Exception {
// First port has no server (TCP refused); second is reachable.
// WalkTracker must classify the first as TransportError and bind
// the second on the same walk (no fall-through reset needed yet).
int portDead = TestPorts.findUnusedPort();
try (TestWebSocketServer ok = new TestWebSocketServer(NOOP_HANDLER)) {
ok.setSendServerInfo(true);
int portOk = ok.getPort();
// Probe the dead port only while ok's listener holds portOk: the
// kernel never hands out a port a live listener owns, so portDead
// cannot collide with portOk. Probing first lets the server's own
// bind(0) receive the just-released probe port, and the duplicate
// addr entry then fails config validation.
int portDead = TestPorts.findUnusedPort();
ok.start();
Assert.assertTrue(ok.awaitStart(5, TimeUnit.SECONDS));

Expand Down
Loading