Repository navigation
Specify and test resolved local date windows - #34
Merged
Merged
Conversation
Terastar-Paperclip
marked this pull request as ready for review
November 10, 2026 00:12
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify an offline resolved-window diagnostic and add reusable black-box checks for local date boundaries. The checks cover extreme UTC offsets and daylight-saving transitions; they run separately during rollout so existing consumers do not break prematurely. Clarify that an inclusive end date ends at the next local midnight, not necessarily 24 hours later.
The first implementation, quantcli/crono-export-cli#57, is merged. The remaining tracked pull requests are assigned to @DTTerastar: quantcli/crono-export-cli#58, quantcli/liftoff-export-cli#70 and quantcli/withings-export-cli#51. Their test dependencies must be repointed to this PR's merged commit before they merge. The status row remains human-attested until the exporter checks are merged.
Validation:
go test ./...incompat/; exercised the shared test against all 14 commands across the three proposed exporter branches. The diagnostic verifies reported dates; exporter-specific tests remain responsible for request and filtering behavior.