Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending

[maulik-k-shah]

Denying idle state entry requires local_irq_enable() before returning back to caller which is missing.

This reverts commit 3caa15b.

CRs-Fixed: 4681020

[qswat-orbit-external]

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4681020 on any of the following entities:

Entities:

• kernel.qli.2.0

CR: 4681020

Please ensure the CR has a change task associated with at least one of the entities for this branch.

[qlijarvis]

PR #1134 — validate-patch

PR: #1134

Verdict	Issues	Detailed Report
⚠️	0	Full report

Final Summary

1. Lore link present: No — Revert commit has no lore link; the original FROMLIST commit being reverted should have had one but it's not referenced here
2. Lore link matches PR commits: N/A — no lore link to compare against (revert commits don't need upstream sources)
3. Upstream patch status: Unknown — cannot determine if the original FROMLIST patch was accepted/rejected upstream without the lore link
4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1134 - Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending"
Upstream commit: N/A (Revert commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check	Status	Note
Subject matches upstream	N/A	Revert commit - no upstream source
Body preserves rationale	✅	Explains why revert is needed (missing local_irq_enable)
Fixes tag present/correct	⚠️	No Fixes tag pointing to the reverted commit
Authorship preserved	✅	Maulik Shah authored the revert
Backport note (if applicable)	N/A	Not a backport

Diff

File	Status	Notes
drivers/cpuidle/cpuidle.c	✅	Clean revert - removes 3 lines checking for pending IPI

Issues

1. Missing reference to original lore link: The commit being reverted (3caa15b2812b4ccf768948cfa4f0fe7329eab5db) was a FROMLIST: patch, which means it should have had a lore.kernel.org link. The revert commit should ideally reference that original lore link to provide context about what's being reverted and why.

2. Missing Fixes tag: The revert should include a Fixes: tag pointing to the commit being reverted (3caa15b2812b4ccf768948cfa4f0fe7329eab5db) to establish the relationship clearly.

3. Incomplete rationale: While the commit message explains that local_irq_enable() is missing, it doesn't explain:

   • Whether the original patch was rejected/accepted upstream
   • Whether this is a temporary revert pending a fix
   • Whether the original approach was fundamentally flawed

Verdict

Merge with minor improvements recommended. The revert is technically correct (removes the problematic code), but the commit message should be enhanced with a Fixes tag and reference to the original lore link for better traceability.

Final Summary

1. Lore link present: No — Revert commit has no lore link; the original FROMLIST commit being reverted should have had one but it's not referenced here
2. Lore link matches PR commits: N/A — no lore link to compare against (revert commits don't need upstream sources)
3. Upstream patch status: Unknown — cannot determine if the original FROMLIST patch was accepted/rejected upstream without the lore link
4. PR present in qcom-next/topics: Yes — present in topics branch at 179ed4395ab2afda9df20c8346bc965b708dbaef

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit	Subject	qcom-next	topics	Final
1/1	[PATCH] Revert "FROMLIST: cpuidle: Deny idle entry when CPU already	missing - no subject, patch-id, or full tree-content match found	present - exact patch-id match at 179ed4395ab2afda9df20c8346bc965b708dbaef	present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

[qlijarvis]

PR #1134 — checker-log-analyzer

PR: #1134
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35261678775

Checker	Result	Summary
Checker	Result	Summary
checkpatch	✅	Passed
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	⏭️	Skipped (no DTS changes)
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	Missing prefix on Revert commit
tag-check	❌	Subject line missing required prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1134 - Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending"
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35261678775
Target branch: qcom-6.18.y

Checker	Result	Summary
checkpatch	✅	Passed
dt-binding-check	⏭️	Skipped (no binding changes)
dtb-check	⏭️	Skipped (no DTS changes)
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	Missing prefix on Revert commit
tag-check	❌	Subject line missing required prefix

---

❌ check-patch-compliance

Root cause: The commit subject line starts with Revert but lacks a required prefix tag before the word Revert.

Failure details:

Checking commit: Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending"
Commit summary does not start with a required prefix

Fix: Add a prefix tag before Revert. Since this is reverting a FROMLIST: patch, use either UPSTREAM: or FROMLIST: depending on the revert's upstream status:

git rebase -i HEAD~1   # mark commit as 'edit'
git commit --amend -m 'UPSTREAM: Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending"'
# Keep the rest of the commit body unchanged
git rebase --continue

Reproduce locally:

cd kernel-checkers
./check-patch-compliance.sh --base <base_sha> --head <head_sha>

---

❌ tag-check

Root cause: The PR targets branch qcom-6.18.y (not qcom-next or qcom-next-staging), which requires every commit subject to start with a valid prefix tag. The current subject Revert "FROMLIST: ..." is missing a prefix before Revert.

Failure details:

Commit a6035ce667cfc463c8a4878dcf5b566e97886458
Subject: Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending"

Required prefix tags: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:

Fix: Same as check-patch-compliance — add a prefix before Revert:

git commit --amend -m 'UPSTREAM: Revert "FROMLIST: cpuidle: Deny idle entry when CPU already have IPI interrupt pending"'

Choose the correct prefix based on the revert's origin:

• If this revert is posted to lore.kernel.org → FROMLIST:
• If this revert is merged into Linus's tree → UPSTREAM:
• If this revert is in a maintainer tree → FROMGIT:

Reproduce locally:

git log --format="%H %s" HEAD~1..HEAD | grep -qE '^[0-9a-f]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):' || echo "FAIL: missing prefix"

---

Verdict

2 blockers must be fixed before merge:

1. Missing subject prefix — The commit subject must start with a valid prefix tag (UPSTREAM:, FROMLIST:, etc.) before the word Revert. This is required for all commits targeting branches other than qcom-next or qcom-next-staging.

2. check-patch-compliance failure — Same root cause as Create qualcomm-linux-organization-repolinter.yml #1; both checks enforce the prefix requirement.

Recommended action: Amend the commit subject to add UPSTREAM: (or the appropriate prefix) before Revert, then force-push to update the PR. All other checkers passed cleanly.

[qcomlnxci]

Test jobs on a6035ce

• multimedia Job 229920 on hamoa-iot-evk
• multimedia Job 229925 on lemans-evk
• multimedia Job 229921 on monaco-evk
• multimedia Job 229922 on purwa-iot-evk
• multimedia Job 229919 on qcs615-ride
• multimedia Job 229923 on qcs6490-rb3gen2
• multimedia Job 229927 on qcs8300-ride
• multimedia Job 229926 on qcs9100-ride-r3
• multimedia Job on qrb2210-rb1
• multimedia Job 229924 on shikra-iqs-evk

[qcomlnxci]

Test Matrix

Test Case	hamoa-iot-evk-multimedia	lemans-evk-multimedia	monaco-evk-multimedia	purwa-iot-evk-multimedia	qcs615-ride-multimedia	qcs6490-rb3gen2-multimedia	qcs8300-ride-multimedia	qcs9100-ride-r3-multimedia	shikra-iqs-evk-multimedia
Audio_Card_Registration	✅ Pass	✅ Pass	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip
BT_FW_KMD_Service	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail
BT_ON_OFF	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail
BT_SCAN	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail
CPUFreq_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
CPU_affinity	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
DSP_AudioPD	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	⚠️ skip
Ethernet_Basic_Validation	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	⚠️ skip	❌ Fail	⚠️ skip
Freq_Scaling	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
GIC	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail
IPA	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
Interrupts	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
KVM_Driver	❌ Fail	✅ Pass	✅ Pass	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail
KVM_EL2_DTB	❌ Fail	✅ Pass	✅ Pass	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail
KVM_Infra	❌ Fail	✅ Pass	✅ Pass	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail
OpenCV	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
PCIe	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail
Probe_Failure_Check	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail	❌ Fail
RMNET	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
UFS_Validation	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	⚠️ skip
USBHost	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	❌ Fail	✅ Pass	✅ Pass	❌ Fail
WiFi_Firmware_Driver	✅ Pass	✅ Pass	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
WiFi_OnOff	✅ Pass	✅ Pass	❌ Fail	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	⚠️ skip
adsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	⚠️ skip
cdsp_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
gpdsp_remoteproc	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip	⚠️ skip	⚠️ skip	✅ Pass	✅ Pass	⚠️ skip
hotplug	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
irq	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
kaslr	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
pinctrl	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
qcom_hwrng	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	◻️
rngtest	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
shmbridge	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
smmu	❌ Fail	❌ Fail	✅ Pass	❌ Fail	❌ Fail	✅ Pass	✅ Pass	❌ Fail	✅ Pass
watchdog	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass
wpss_remoteproc	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass	✅ Pass