Skip to content

fix: read model text files as UTF-8 regardless of platform locale #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joein merged 3 commits into from
Oct 28, 2026
Merged

fix: read model text files as UTF-8 regardless of platform locale #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d334c6a
fix: read model text files as UTF-8 regardless of platform locale
Aditya17-bot Oct 6, 2026
f477c4c
tests: remove text file encoding tests
joein Oct 28, 2026
bc02b23
fix: read only third-party model files as utf-8
joein Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions fastembed/common/preprocessor_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def load_special_tokens(model_dir: Path) -> dict[str, Any]:
if not tokens_map_path.exists():
return {}

with open(str(tokens_map_path)) as tokens_map_file:
with open(str(tokens_map_path), encoding="utf-8") as tokens_map_file:
tokens_map = json.load(tokens_map_file)

return tokens_map
Expand Down Expand Up @@ -84,10 +84,10 @@ def load_tokenizer(model_dir: Path) -> tuple[Tokenizer, dict[str, int]]:
config_path = model_dir / "config.json"
config: dict[str, Any] = {}
if config_path.exists():
with open(str(config_path)) as config_file:
with open(str(config_path), encoding="utf-8") as config_file:
config = json.load(config_file)

with open(str(tokenizer_config_path)) as tokenizer_config_file:
with open(str(tokenizer_config_path), encoding="utf-8") as tokenizer_config_file:
tokenizer_config = json.load(tokenizer_config_file)

max_context = _resolve_max_context(tokenizer_config, model_dir)
Expand Down Expand Up @@ -153,7 +153,7 @@ def load_preprocessor(model_dir: Path) -> Compose:
if not preprocessor_config_path.exists():
raise ValueError(f"Could not find preprocessor_config.json in {model_dir}")

with open(str(preprocessor_config_path)) as preprocessor_config_file:
with open(str(preprocessor_config_path), encoding="utf-8") as preprocessor_config_file:
preprocessor_config = json.load(preprocessor_config_file)
transforms = Compose.from_config(preprocessor_config)
return transforms
2 changes: 1 addition & 1 deletion fastembed/sparse/bm25.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def _load_stopwords(cls, model_dir: Path, language: str) -> list[str]:
if not stopwords_path.exists():
return []

with open(stopwords_path, "r") as f:
with open(stopwords_path, "r", encoding="utf-8") as f:
return f.read().splitlines()

def _embed_documents(
Expand Down
Loading