Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
+ Coverage 93.90% 93.98% +0.08%
==========================================
Files 89 89
Lines 13924 13989 +65
==========================================
+ Hits 13075 13148 +73
+ Misses 849 841 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Performance numbers from Claude: Overall the PR is about 1.5× slower than main across these cases, and full-disk sources are unchanged. Partial-disk sources are 1.1–3.3× slower, but in 7 of the 9 partial-disk cases main's faster answer was a slice that was too small (or an error). The table compares main (94eabc2) with your PR commit (c4da9ce). Each time is the median of 7 runs, and the "missing pixels" column comes from those same two commits. It's in a code block so the raw markdown survives copying, and it's also saved as pr_perf_table.md in my scratchpad (/tmp/claude-53807/-home-davidh-repos-git-pyresample/2c77a686-8f1c-4596-acbb-2a73545294c7/scratchpad/pr_perf_table.md).
Times are the median of 7 calls to ¹ Time until Full-disk sources are unchanged because their outline is identical. Partial-disk sources are 1.1–3.3× slower. Nearly all of the time is in the pure-Python spherical polygon intersection, which slows down as vertices are added.
|
c4da9ce to
4662c4b
Compare
|
I've now rebased this branch and moved the work in #729 to use the same functionality that was used in this PR. Pretty much the same logic just a little more flexible. Now the two slicing code branches use the same code for geostationary segmenting. |

This is an extension of #729 that applies the same idea to general
get_area_slices. I had been working with Claude on reviewing #729 and #700 as they deal with similar issues. Claude pointed out flaws in #700 and suggested that until spherical intersection calculations in pyresample are better, #729's solution would be a clean replacement for what #700 is doing.Claude wrote this code. I asked it to make a better suite of tests that borrowed from the assertions in #700, but with more cases. One of the flaws of #700 is that it really only makes the calculations better where the target area is completely inside the source area. I wanted more cases.
I don't think #700 should be merged and instead #729 and this PR should be merged. I'll have Claude update this PR with a shared helper function once I merge #729.