gh-148501: Disable AArch64 Mach-O LOH for JIT stencils - #157040
Open
lgeiger wants to merge 2 commits into
Open
Conversation
lgeiger
requested review from
brandtbucher,
diegorusso and
savannahostrowski
as code owners
September 6, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, LLVM’s AArch64 Mach-O linker optimisation hints prevent the JIT optimiser from folding
adrp/ldrconstant loads intomovz. These hints are actually unused because stencils are not directly passed to the Mach-O linker.This PR disables the linker hints on macOS Aarch64 with
-aarch64-enable-collect-loh=false.E.g. the stencil for
_LOAD_SMALL_INT_r01on macOS currently looks something like this:After this PR, the linker optimisation hints are removed and the JIT optimiser can correctly fold
adrp/ldrconstant loads.Overall, this reduces the size of all stencils on macOS by 4.5%:
I ran the pyperformance suite before and after on a Apple M5 Pro which suggests a geometric mean improvement of 0.57% and up to 7.3% faster on
scimark_sparse_mat_mult.Expand for full benchmarking results
Benchmarks and code size analysis was run by GPT 5.6 Sol. Code changes are authored by myself.
I realised too late that work on the JIT is currently paused. I'm still opening the PR since #148501 is labeled as a bug, but feel free to ignore it until there's an official decision on the PEP by the steering council.
A follow up to this would be to recognise the
@GOTPAGE/@GOTPAGEOFFDarwin syntax similar to what's done for the:got:/:got_l12:ELF syntax sopatch_aarch64_33rxcan deal with it.