[3.13] gh-154175: Fetch _PY_GIL_DROP_REQUEST_BIT under GIL - #157013
Open
cmaloney wants to merge 1 commit into
Open
[3.13] gh-154175: Fetch _PY_GIL_DROP_REQUEST_BIT under GIL#157013cmaloney wants to merge 1 commit into
cmaloney wants to merge 1 commit into
Conversation
Once the GIL is released the tstate may be freed which shows up as ASAN and TSAN failures in test_io with daemon threads. Check the bit before dropping the GIL so the tstate is guaranteed to still be allocated. Remove the TSAN suppressions which were added for 3.13 as this should fix this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the GIL is released
tstatemay be freed which shows up as ASAN and TSAN failures intest_iowith daemon threads. Check the bit before dropping the GIL so the tstate is guaranteed to still be allocated.Remove the TSAN suppressions which were added for 3.13 as this should fix this case.
cc: @colesbury , @gpshead from main branch fix gh-124878