gh-152490: Fix TypeError when formatting SyntaxError with msg=NotImplemented in traceback.py - #152495
Open
Aniketsy wants to merge 10 commits into
Open
gh-152490: Fix TypeError when formatting SyntaxError with msg=NotImplemented in traceback.py#152495Aniketsy wants to merge 10 commits into
traceback.py#152495Aniketsy wants to merge 10 commits into
Conversation
picnixz
reviewed
Jun 28, 2026
terryjreedy
requested changes
Jun 28, 2026
terryjreedy
left a comment
terryjreedy
left a comment
Member
There was a problem hiding this comment.
I have no opinion on the test change.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…8qLbF.rst Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
picnixz
reviewed
Jun 29, 2026
| with self.assertRaisesRegex(TypeError, 'required positional argument'): | ||
| traceback.format_exception(exc=e) | ||
|
|
||
| def test_format_exception_only_exc(self): |
Contributor
Author
|
@picnixz i've updated with changes, as per your suggestion. please let me know if we need any further improvements. Thanks :) |
picnixz
self-requested a review
July 3, 2026 19:23
picnixz
reviewed
Sep 6, 2026
picnixz
reviewed
Sep 6, 2026
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
reviewed
Sep 6, 2026
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152490