docs(django): document launch bridge endpoints feature - #510
Open
peterfarrell wants to merge 2 commits into
Open
peterfarrell wants to merge 2 commits into
peterfarrell wants to merge 2 commits into
Conversation
Add comprehensive documentation for the launch bridge endpoints feature introduced in python-social-auth/social-app-django#1092 (#1020).
Documentation build overview
|
Contributor
Author
|
@nijel ready for review in conjunctions with PR python-social-auth/social-app-django#1092 (#1020). |
Member
|
@codex review |
nijel
reviewed
Sep 22, 2026
|
|
||
| .. code-block:: python | ||
|
|
||
| from social_django.utils import LaunchBridge |
Member
There was a problem hiding this comment.
Does this really work in settings? The utils imports models and should need app registry ready. So I'd expect this to fail with `AppRegistryNotReady.
|
|
||
| .. code-block:: python | ||
|
|
||
| SOCIAL_AUTH_OKTA_ALLOWED_ID_TOKEN_ISSUERS = [ |
Member
There was a problem hiding this comment.
Suggested change
| SOCIAL_AUTH_OKTA_ALLOWED_ID_TOKEN_ISSUERS = [ | |
| SOCIAL_AUTH_OKTA_OAUTH2_ALLOWED_ID_TOKEN_ISSUERS = [ |
| Designed for same-origin frontend or SPA redirects. Enforces 9 security layers: | ||
|
|
||
| 1. **Opt-In Gate**: Raises ``Http404`` if ``LaunchBridge.APP`` (or | ||
| ``'app_launch'``) is not present in ``SOCIAL_AUTH_ENABLE_LAUNCH_BRIDGES``. |
Member
There was a problem hiding this comment.
Doesn't this also require a backend that supplies a valid HTTPS issuer?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive documentation for the launch bridge endpoints feature
introduced in python-social-auth/social-app-django#1092 (#1020).
SOCIAL_AUTH_ENABLE_LAUNCH_BRIDGESidp_launchandapp_launchlaunch.html