Repository navigation
Use Turkish numeric separators - #465
Open
emrehangorgec wants to merge 1 commit into
Open
emrehangorgec wants to merge 1 commit into
emrehangorgec wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activating
tr_TRtranslates words but leaves English numeric separators.intcomma(1_234_567.89)returns1,234,567.89, and the Turkish string"1234567,89"is read as123,456,789.Changes proposed in this pull request:
tr_TRwith a dot for grouping and a comma for decimals, following Unicode CLDR.intcommaandintwordlocale tests, and add a README example.Found through code inspection and reproduced locally. Three regression checks fail before the fix. No matching issue or PR was found.
Validation on Windows with Python 3.14:
python -m pytest tests src/humanize --doctest-modules --benchmark-disable --cov=humanize: 873 passed, 99% coverage.python -m mypy .: passed for all 14 source files.prek run --all-files --show-diff-on-failure: passed.git diff --checkpassed.Translation catalogs were compiled before testing. Local hook setup required reinstalling
validate-pyproject==0.26to restore missing schema files. Benchmark timings and other platforms were not tested.Does this handle Turkish numeric inputs as intended, including strings passed to
intcomma?