ci: pass greenlight review secrets by name in greenlight-review.yml - #138
Merged
Merged
Conversation
secrets: inherit does not pass secrets to a reusable workflow in another org, so the dourolabs greenlight-review-impl workflow got no credential. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexcambose
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
In
.github/workflows/greenlight-review.yml, the call todourolabs/greenlight-actions/.github/workflows/greenlight-review-impl.yml@v1now passesANTHROPIC_API_KEYandCLAUDE_CODE_OAUTH_TOKENby name. It no longer usessecrets: inherit.Why
secrets: inheritpasses secrets to a reusable workflow only when the caller and the reusable workflow are in the same org or enterprise. pyth-network and dourolabs are different orgs, so GitHub passed no secrets, and every review failed with "The review agent has no credential".The impl workflow declares both secrets as optional. An unset secret renders empty, and the impl workflow treats empty as absent, so its "exactly one credential" check still works.
Required setup
The pyth-network org secret (
ANTHROPIC_API_KEYorCLAUDE_CODE_OAUTH_TOKEN) must also be shared with this repo for reviews to pass. We could not verify this with the agent token.Checks
js-yaml.grepfinds no other reference tosecrets: inheritin this repo.🤖 Generated with Claude Code