Fix asset filename truncation to account for assets/ prefix - #1069
Open
guoyuxiao946b wants to merge 1 commit into
Open
Fix asset filename truncation to account for assets/ prefix#1069guoyuxiao946b wants to merge 1 commit into
guoyuxiao946b wants to merge 1 commit into
Conversation
Reserve the assets directory prefix when truncating extra filenames so relative paths stay within max_asset_filename_length. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extras are written to disk,
_asset_filenametruncated names tomax_asset_filename_length(default 255) andReport._write_contentthen joined them with theassets/directory. The relative path could exceed the configured limit and fail on Windows MAX_PATH.Reserve the assets directory name plus separator when truncating. Self-contained reports do not write an assets directory and are unchanged.
Closes #906
Made with Cursor