Repository navigation
Adding decomposed FoKL GPs into PyBOP - #978
derek-slack wants to merge 15 commits into
Conversation
|
I fixed the issue where the end user needed to use indices to call function inputs instead of strings: User can now select from the set of passed children to the function by referencing the string in the |
Co-authored-by: NicolaCourtier <45851982+NicolaCourtier@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #978 +/- ##
===========================================
+ Coverage 92.13% 93.04% +0.91%
===========================================
Files 74 85 +11
Lines 5799 6991 +1192
===========================================
+ Hits 5343 6505 +1162
- Misses 456 486 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
This push adds the ability to create FoKL GPs as parameter functions of the state of the cell.
Fixes # 672
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).
Important checks:
Please confirm the following before marking the PR as ready for review:
No style issues:
$ pre-commit runor$ nox -s pre-commit(see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)All tests pass:
nox -s testsThe documentation builds:
nox -s doctestCode is commented for hard-to-understand areas
Tests added that prove fix is effective or that feature works