Skip to content

calc_surface_orientiation returns scalar when input is scalar #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cwhanse wants to merge 3 commits into
base: main
Choose a base branch
from
+11 −2
Open

calc_surface_orientiation returns scalar when input is scalar #2882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f18c29b
return scalar when input is scalar
cwhanse Oct 3, 2026
83526e3
Merge branch 'main' of https://github.com/pvlib/pvlib-python into sca…
cwhanse Oct 3, 2026
180f625
whatsnew
cwhanse Oct 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/sphinx/source/whatsnew/v0.16.2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ Deprecations

Bug fixes
~~~~~~~~~

* :py:func:`pvlib.tracking.calc_surface_orientation` returns scalar when input
is scalar (:issue:`2881`, :pull:`2882`)

Enhancements
~~~~~~~~~~~~
Expand Down Expand Up @@ -42,4 +43,4 @@ Maintenance

Contributors
~~~~~~~~~~~~

* Cliff Hansen (:ghuser:`cwhanse`)
5 changes: 5 additions & 0 deletions pvlib/tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,11 @@ def calc_surface_orientation(tracker_theta, axis_tilt=0, axis_azimuth=0):
surface_azimuth = np.degrees(
np.arctan2(unit_normal[..., 0], unit_normal[..., 1]))

# above always returns a np.array
# return scalar if `tracker_theta` is a scalar
if np.isscalar(tracker_theta):
surface_azimuth = surface_azimuth.item()

surface_azimuth = np.where(surface_tilt == 0., axis_azimuth - 90.,
surface_azimuth)
# constrain angles to [0, 360)
Expand Down
3 changes: 3 additions & 0 deletions tests/test_tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,9 @@ def test_calc_surface_orientation_types():
out = tracking.calc_surface_orientation(rotation)
assert out['surface_tilt'] == pytest.approx(expected_tilt)
assert out['surface_azimuth'] == pytest.approx(expected_azimuth)
# confirm scalar output when input is scalar
assert np.isscalar(out['surface_tilt'])
assert np.isscalar(out['surface_azimuth'])


def test_calc_surface_orientation_kwargs():
Expand Down
Loading