Repository navigation
ci(mutants): cap lints on in-diff mutant builds, so -D warnings stops turning every mutant unviable (#400) - #524
Merged
Merged
Conversation
…ps turning every mutant unviable (#400) #522's per-PR gate ran `cargo mutants --in-diff` under the workflow-wide RUSTFLAGS "-D warnings". A mutant that replaces a function body leaves its parameters unused, and -D warnings makes that a compile error ("unused variable: `inst`"). On #517 all 9 selected mutants were therefore UNVIABLE, nothing was caught, and the gate's "none caught" rule failed the PR with no test ever having run. Same diff measured locally under RUSTFLAGS="-D warnings": 9 unviable, reproduced exactly. `--cap-lints=true` makes cargo-mutants cap lint levels for mutated builds. Same diff, same RUSTFLAGS, with the flag: 9 selected, 6 caught, 3 unviable, 0 missed, matching the local run without -D warnings. Only the in-diff step changes. The full-crate run keeps -D warnings, because its 292 ratchet was measured under it and capping would change which mutants compile. The "none caught → FAIL" rule did its job here. It refused to read "0 missed" from a run in which no test executed. Refs #400, #496 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BnBWxgVEUPdsBTLNKtrA6Z
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Rivet verification gate✅ 20/20 passed
Filter: Failed artifacts(none) Updated automatically by |
This was referenced Oct 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#522's per-PR gate ran
cargo mutants --in-diffunder the workflow-wideRUSTFLAGS "-D warnings". A mutant that replaces a function body leaves
its parameters unused, and -D warnings makes that a compile error
("unused variable:
inst"). On #517 all 9 selected mutants weretherefore UNVIABLE, nothing was caught, and the gate's "none caught"
rule failed the PR with no test ever having run. Same diff measured
locally under RUSTFLAGS="-D warnings": 9 unviable, reproduced exactly.
--cap-lints=truemakes cargo-mutants cap lint levels for mutatedbuilds. Same diff, same RUSTFLAGS, with the flag: 9 selected, 6 caught,
3 unviable, 0 missed, matching the local run without -D warnings.
Only the in-diff step changes. The full-crate run keeps -D warnings,
because its 292 ratchet was measured under it and capping would change
which mutants compile.
The "none caught → FAIL" rule did its job here. It refused to read "0
missed" from a run in which no test executed.
Refs #400, #496
🤖 Generated with Claude Code
https://claude.ai/code/session_01BnBWxgVEUPdsBTLNKtrA6Z