ci: pin Playwright E2E to ubuntu-24.04 so chromium installs again by avrabe · Pull Request #1114 · pulseengine/rivet

avrabe · 2026-10-21T16:43:18Z

Summary

Pins the Playwright E2E job to ubuntu-24.04. GitHub's ubuntu-latest now resolves to Ubuntu 26.04, which the pinned Playwright release does not support — npx playwright install --with-deps chromium fails before any test runs with:

Error: ERROR: Playwright does not support chromium on ubuntu26.04-x64

The E2E suite therefore stopped running on every PR and on main. This pin is the smallest change that restores coverage today; the comment above runs-on records the reason so the pin is removed deliberately once Playwright publishes a release that supports 26.04.

Closes #1109.

Acceptance criteria

Issue #1109 proposes two fix options and raises one gate-related note:

Pin the job to ubuntu-24.04 until Playwright supports 26.04 — done at .github/workflows/ci.yml line 558 (now runs-on: ubuntu-24.04). The alternative — bumping Playwright — was not pursued because no release that supports 26.04 is published yet; a bump can replace the pin when one is.
Record the pin's reason above runs-on — done. The existing block comment above the job now carries a new paragraph tagged #1109 that names the error, the version pinned, and the condition for removing the pin.
Gate note (advisory vs required) — not changed. Playwright is deliberately listed in the CI Gate's "Deliberately NOT gated on" paragraph (near ci-gate.needs), so a non-running E2E suite reads as advisory by design. The issue flagged this for discussion; this PR surfaces it in the body and leaves the gate shape alone, since promoting it is a separate decision and widening scope beyond ci: Playwright E2E fails on every run since ubuntu-latest became Ubuntu 26.04 (chromium unsupported) #1109.

Test plan

CI runs this PR against the pinned runner and the Playwright E2E job reaches the test body (not the install step error).
The job's playwright-report artifact is uploaded.
Format / Clippy / cargo-deny stay green — this PR is CI-config-only, no Rust touched.

Generated by Claude Code

Playwright E2E was failing on this PR too for the same reason main is red: `ubuntu-latest` now resolves to Ubuntu 26.04, and the pinned Playwright release's `install --with-deps chromium` fails before any test runs with "Playwright does not support chromium on ubuntu26.04-x64". The failure is base-branch state, not this PR's diff (which only touches `rivet-cli/src/main.rs` and `rivet-cli/tests/cli_commands.rs`). Porting the one-line pin from #1114 so the Playwright gate on THIS PR sees the test body instead of the install error. No-ops once #1114 merges. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018W8367wHNy5cYzU8yqjAre

codecov · 2026-10-22T02:01:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

`ubuntu-latest` now resolves to Ubuntu 26.04, which the pinned Playwright release does not support -- `npx playwright install --with-deps chromium` fails before any test runs with "Playwright does not support chromium on ubuntu26.04-x64", so the E2E suite stopped running on every PR and on main. Pin the job to ubuntu-24.04 (the smallest change that restores coverage today) and record the pin's reason in the job comment so the pin is removed deliberately once Playwright supports 26.04. The job is deliberately not in the CI Gate's needs block (see the "Deliberately NOT gated on" comment that lists Playwright), so a non-running E2E suite shows as advisory. That is a documented design choice and this PR does not change it. Fixes #1109 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0178yG1Xjfzj9oHuGc74wHET

avrabe · 2026-10-22T10:54:16Z

Rebased onto main (9e6fb60, the v0.41.1 review-findings merge) so it can land before the v0.41.1 tag — maintainer decision: merge the Playwright pin first so E2E runs on the release commit.

github-actions

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: `abe61c3`	Previous: `cc3b807`	Ratio
`diff/10000`	`10428744` ns/iter (`± 556397`)	`8557364` ns/iter (`± 724270`)	`1.22`

This comment was automatically generated by workflow using github-action-benchmark.

avrabe · 2026-10-22T12:56:50Z

Benchmark alert is not from this PR's diff. The alert compares abe61c35 (this PR, rebased) against cc3b8075 (two commits back), so the delta covers 9e6fb60 — the #1111 scan/walker changes merged into main — plus this commit. This PR touches only .github/workflows/ci.yml, which cannot move diff/10000 ns/iter. For reference, the first CI pass on this PR before the rebase (9b6cb08, same CI change on the pre-#1111 base) returned Criterion Benchmarks as success with no alert. The Criterion check itself concluded success here too; the warning is informational only. Not widening this PR; if the regression is confirmed real on main, it is a follow-up against #1111's changes.

Playwright E2E on the rebase: success — the pin still fixes the install step.

Generated by Claude Code

…rom #1114) Playwright E2E failed on this PR's first CI run with the same install error as #1109: `ubuntu-latest` now resolves to Ubuntu 26.04 and the pinned Playwright release fails with "Playwright does not support chromium on ubuntu26.04-x64". The diff is `.github/workflows/ci.yml:558` only — Rust is untouched. Ported verbatim from PR #1114 so the fix lands here now rather than waiting on that PR to merge: it no-ops once main carries it, and until then it keeps this PR's Playwright job honest (same approach the posture calls for on a failure whose fix already exists). The pin stays until Playwright publishes a release that supports 26.04. Refs: FEAT-001 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015gifkRw7MTUK8ayW4Bighz

avrabe · 2026-10-22T13:38:16Z

Proptest (extended) is red here but passed on 9e6fb60 (main) under the same job name — so this isn't my diff's doing. The failures are all rivet-cli::serve_integration tests panicking at serve_integration.rs:109 with "server did not become healthy within 30 seconds on port ", with 22 flaky passes alongside the 20 TRY 3 fails. Classic hardcoded-timeout flake on the self-hosted runner, with nothing in .github/workflows/ci.yml's pin that could affect server bring-up. CI Gate's needs doesn't include Proptest (deliberately, per the "Deliberately NOT gated on" comment near ci-gate.needs), so this is advisory — not a required check. Will re-run the failed jobs once to confirm the flake; not widening this PR to touch serve_integration startup, since the fix (if any) belongs on main as a separate change.

Generated by Claude Code

avrabe mentioned this pull request Oct 21, 2026

ci: Playwright E2E fails on every run since ubuntu-latest became Ubuntu 26.04 (chromium unsupported) #1109

Closed

avrabe mentioned this pull request Oct 22, 2026

fix(cli): widen rivet add --id to the shapes the loader loads (#1088) #1116

Open

7 tasks done

avrabe force-pushed the fix/issue-1109-playwright-ubuntu-pin branch from 9b6cb08 to abe61c3 Compare October 22, 2026 10:54

github-actions Bot reviewed Oct 22, 2026

View reviewed changes

avrabe mentioned this pull request Oct 22, 2026

fix(cli): --set-release "" clears the field so an artifact goes to backlog (#1115) #1120

Open

7 of 9 tasks

avrabe mentioned this pull request Oct 22, 2026

serve_integration: 30 s health timeout sits at the edge of loaded-runner startup time (Proptest job fails ~30 tests at once) #1121

Open

avrabe merged commit 29ca438 into main Oct 22, 2026
63 of 64 checks passed

avrabe deleted the fix/issue-1109-playwright-ubuntu-pin branch October 22, 2026 15:58

Navigation Menu

Repository navigation

ci: pin Playwright E2E to ubuntu-24.04 so chromium installs again - #1114

ci: pin Playwright E2E to ubuntu-24.04 so chromium installs again#1114
avrabe merged 1 commit into
mainfrom
fix/issue-1109-playwright-ubuntu-pin

avrabe commented Oct 21, 2026

Uh oh!

codecov Bot commented Oct 22, 2026

Uh oh!

avrabe commented Oct 22, 2026

Uh oh!

github-actions Bot left a comment

Uh oh!

avrabe commented Oct 22, 2026

Uh oh!

avrabe commented Oct 22, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

avrabe commented Oct 21, 2026

Summary

Acceptance criteria

Test plan

Uh oh!

codecov Bot commented Oct 22, 2026

Codecov Report

Uh oh!

avrabe commented Oct 22, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

⚠️ Performance Alert ⚠️

Uh oh!

avrabe commented Oct 22, 2026

Uh oh!

avrabe commented Oct 22, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants