Repository navigation
Conversation
Robot Framework suites are tests, but `test_scanner::detect_language` had no entry for `.robot` or `.resource`, so `# rivet: verifies REQ-NNN` markers in those files were silently skipped — the suite could never be credited as verification evidence and inflated the reporter's warning count by 145. Same shape as the shell gap (REQ-319), the yaml/toml gap (REQ-352) and the lean/rocq gap (#992): the pattern itself was never the obstacle; `scan_file` bailed before any pattern ran. Fix: add `robot` as its own language in `default_patterns` (`#` comments, matching Robot Framework syntax), map `.robot` and `.resource` to it in `detect_language`, and add it to `find_enclosing_function`'s early-return list (Robot test cases are names under `*** Test Cases ***`, not functions — a guessed name would be an REQ-326-shape misattribution). Verified by two new tests: one asserts both extensions are credited; the other plants a `def helper(` above the marker to prove the `robot` guard is load-bearing against the generic catch-all. Fixes: REQ-389 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E1rzxvHN7qT1UaX8GEtcYw
|
The diff is a single Rust-logic change in
All six predate this PR, and the same check was green on the latest scheduled main run (2026-10-19). The No fix PR exists yet. The right fix is a separate CI-only change: either pin Will spend my one allotted re-run to confirm it reproduces, then wait on the fix landing on main. Generated by Claude Code |
|
GitHub's Fix for a separate CI PR: either bump the Playwright pin to a version that supports 26.04, or pin the runner to Generated by Claude Code |
📐 Rivet artifact deltaNo artifact changes in this PR. Code-only changes (renderer, CLI wiring, tests) don't touch the artifact graph. |
|
Two newly-published wasmtime 48.0.6 CVEs:
Both have the same fix: Not porting into this PR to keep the diff focused on #1105. A separate Generated by Claude Code |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Superseded by #1108 (merged as cc3b807, ships in v0.41.1, REQ-407): |
Closes #1105
Summary
test_scanner::detect_languagehad no entry for Robot Framework (.robot,.resource), so# rivet: verifies REQ-NNNmarkers in Robot suites were silently skipped. Reported downstream: 145 inflated warnings from a project whose tests are Robot Framework suites.Same shape as the shell gap (REQ-319), the yaml/toml gap (REQ-352) and the lean/rocq gap (#992) — the pattern itself was never the obstacle;
scan_filebailed before any pattern ran.Fix
robotas its own language indefault_patterns, using#comments..robotand.resourcetorobotindetect_language.robottofind_enclosing_function's early-return list (Robot test cases are names under*** Test Cases ***, not functions — guessing a name would be the REQ-326 misattribution shape the Lean/Rocq guard already prevents).Acceptance criteria from the issue
.robot/.resourcefiles are scanned with#comments.detect_languagenow maps both extensions to"robot", anddefault_patternscarries a matching entry.robot_framework_files_are_scanned_for_markersplaces the marker on the line aboveMy Test Case(andMy Keywordin a.resourcefile) and asserts both ids are found..robotfixture asserts the marker is credited. Addedrobot_framework_files_are_scanned_for_markersinrivet-core/src/test_scanner.rs.robot_markers_fall_back_to_file_and_lineplantsdef helper(above the marker; removing the"robot"guard fromfind_enclosing_functionlatches the generic catch-all ontohelperand theassert_ne!(test_name, "helper")fails. The two assertions together kill a mutant that drops either the extension mapping or the enclosing-function guard.Test plan
cargo test -p rivet-core --lib test_scanner::— 27 passed (both new tests included).Generated by Claude Code