Repository navigation
fix(sitl-gz): retire the legacy hover scenario; default to flightcore (#477) - #595
Merged
Merged
Conversation
…; unknown scenario exits 2 (#477) `--scenario=hover` ran the legacy five-stage cascade (relay-ekf -> pos -> att -> rate) and diverged on main: 74.63 m at 25 s on the mock plant, reproduced on this branch's base before the change. It was also the DEFAULT, and every unknown scenario name silently fell back to it, so a typo measured a diverging path under the name the operator typed. - remove the `hover` arm and `run_closed_loop_hover` - DEFAULT_SCENARIO = "flightcore" (holds 0.04 m at 25 s on the same plant) - SCENARIOS lists every dispatched name; main refuses anything else with exit 2 before opening evidence or connecting to gz - test `legacy_hover_is_retired_and_the_default_flies_the_flight_core` - SWREQ-FALCON-SIM-P04 gains a retirement note; README/script docs updated No CI job runs `hover`: every gz/soak invocation names its scenario. Refs #477 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HvusAXYbHLyv3uTzfBcMbG
Contributor
✅ Rivet verification gate — falcon176/176 passed
Bench-only artifacts (not run by CI)
Source of truth: |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the maintainer decision on #477 (2026-10-21): retire the legacy
hoverscenario and make a scenario that flies the current stack the default.Measured on the base commit, before the change
falcon-sitl-gz --backend=mock --duration=25:hover(old default)flightcore(new default)The mock plant reads 0.00 m horizontally by construction, so only the vertical figure carries information there.
Change
hoverarm andrun_closed_loop_hover, the legacy relay-ekf → pos → att → rate cascadeDEFAULT_SCENARIO = "flightcore"SCENARIOSlists every dispatched name.mainrefuses anything else with exit 2, before it opens evidence or connects to gz. Previously an unknown name fell back silently tohover, so a typo measured the diverging path under the name the operator had typed.legacy_hover_is_retired_and_the_default_flies_the_flight_coreChecked
cargo test -p falcon-sitl-gz: 32/32 pass, including the new test--scenario=hoverexits 2; the default runsflightcoreand passes;supervised-rotoroutstill passesrivet validatePASS (403 warnings, the same as main)hover: every gz and soak invocation names its scenario explicitlyNot armed for auto-merge: #588 goes first in the merge order.
Refs #477. The issue stays open until the change ships in a tagged release.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HvusAXYbHLyv3uTzfBcMbG