Repository navigation
Conversation
The Reddit pixel (pixel.js, about 25 KB) was loaded on every docs page and the two preconnect hints competed with critical requests on first load. The loader code is kept commented out in Root.tsx. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015P6w6i7rSbhg1u7Qqj6d2U
Adds @docusaurus/faster and sets future.experimental_faster so the docs build uses Rspack, SWC and the Lightning CSS minifier. The SSG worker threads option requires future.v4.removeLegacyPostBuildHeadAttribute. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015P6w6i7rSbhg1u7Qqj6d2U
Owner
Author
|
The The job fails with Generated by Claude Code |
MDX wrapped the multi-line image block into an inner <p>, which produced invalid nested paragraphs. The HTML minifier of Docusaurus Faster reported this as a static site generation warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015P6w6i7rSbhg1u7Qqj6d2U
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
Every docs page loaded the Reddit pixel (
https://www.redditstatic.com/ads/pixel.js, about 25 KB) and sent twopreconnecthints towww.redditstatic.comandpixel-config.reddit.com. These compete with the page's own critical requests during first load. The docs build also used webpack and Babel, which is slower and produces larger bundles than Rspack and SWC.Changes:
docs-src/src/theme/Root.tsx: the Reddit pixel loader inloadMarketingPixels()is commented out (kept for later re-enabling).triggerTrackingEvent()already checkstypeof window.rdt === 'function', so the existing Reddit event calls become no-ops.docs-src/docusaurus.config.ts: removed the two Redditpreconnecthead tags.docs-src/package.json+docusaurus.config.ts: added@docusaurus/fasterand enabledfuture.experimental_faster(Rspack, SWC loader and minifier, Lightning CSS minifier, SSG worker threads). The SSG worker threads requirefuture.v4.removeLegacyPostBuildHeadAttribute: true.docs-src/docs/articles/electron-sqlite.md: the header image block produced a nested<p>(invalid HTML). The HTML minifier used by Docusaurus Faster reported it as an SSG warning. Now on one line, so the output is a single<p align="center">.Not changed: the privacy page (
docs-src/src/pages/privacy.tsx) still describes the Reddit Pixel.Verification
Local
docusaurus buildwith clean caches, afternpm install,npm run buildin the root andnpm installindocs-src:main.js(raw)The docs are only built in the
Publish Docsworkflow (on release or manual dispatch), so PR CI does not cover this change. Theexample-ionicfailure on this PR comes from #9102 onmaster, see the comment below.Todos
Assisted by
🤖 Generated with Claude Code
https://claude.ai/code/session_015P6w6i7rSbhg1u7Qqj6d2U