Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the supported range from 31–33 to 32–34 and bumps the app to 1.1.0.
What changes
appinfo/info.xml:min-version="32" max-version="34", version1.1.0.stable31and addsstable34on PHP 8.3.nextcloud/ocpis pinned todev-stable32. The pin tracks the oldest supported version, so Psalm still catches calls to APIs newer than the floor.No PHP code changes. The NC 33 → 34 diff for everything we hook into is attributes and refactors only:
GroupInterface,ISearchPlugin/ collaborator search,Group::inGroup()aggregationuser_ldapAccess/ proxy methodsLdapSynccallsThe one real NC 34 change: where the share check lives
From 34.0.2 the "Sharing is only allowed within your own groups" check is no longer in
Share20\Manager::groupCreateChecks(). It moved to core'sRestrictInteractionListener, whichgeneralChecks()reaches via aRestrictInteractionEvent. It still asksIGroup::inGroup(), so the virtual-membership backend works unchanged.The listener runs for the share owner as well as the sharer whenever the owner is known and differs:
createShare()runsgeneralChecks()before it sets the owner.The app can't change this without answering YES for a non-teacher, which would break the school boundary. It's documented in
SHARING-INTERNALS.mdand theAGENTS.mddiagram.Testing
dev-stable32stubs.dev/ldapseed, over the OCS API as the five seed accounts: