Repository navigation
chore: bump version to 1.0.2 - #31
Merged
Merged
Conversation
|
Looks good to me and I think 1.0.2 instead of 1.1.0 is fine. Due to the app being Puavo-specific and not available in the Nextcloud app store it is unlikely that it would be used anywhere else than internally by Puavo/Opinsys. Therefore we don't have to be extra careful with the version number schema even if the exit code changes in one special case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
appinfo/info.xmlto 1.0.2 for release.What's in it
Three fixes, all in the LDAP sync's prune path, all merged since
v1.0.1:safeSearch()returned[]both for an empty page and for a thrown search; an empty page ends the paging loop, so one transient failure emptied both tables and blanked every teacher's picker until the next good run.NOT INlist. Past 1000 groups that logged an error on every sync (every 15 minutes, with a stack trace), and would genuinely fail on Oracle and on SQLite builds older than 3.32. Fixes LdapSync fails when more than 1000 groups:deleteNotIn()exceeds QueryBuilder IN-list limit #25.puavoEduGroupTyperename, or the bind agent losing read access to it, emptied both tables with exit 0 and no warning. Fixes Sync empties the tables when a completed LDAP walk matches zero class groups #28.occ groupsharemachine:syncnow reportsPRUNE SKIPPED: <reason>on the affected line and exits non-zero when a run was not trustworthy enough to prune against.Not in it
occ upgradehas nothing to run for this version.min-version="31" max-version="33". The NC 34 bump is separate and still pending.Why 1.0.2 and not 1.1.0
Bug fixes only, no new features and no schema change. The one argument for a minor bump is that
occ groupsharemachine:synccan now exit non-zero where it always exited 0, which is a change to a documented interface — but that exit code is the fix, so patch reads right to me. Say if you'd rather signpost it as 1.1.0.Verified
makeproduces a tarball carrying<version>1.0.2</version>. Full gate green onmain: phpunit 56/56, Psalm clean, php-cs-fixer clean.The README's install example pointed at
v1.0.0, which would have handed an admin a build without the class-group search fix; it now names the current tag.After merging
Per the README release steps:
then attach
build/groupsharemachine.tar.gzto the GitHub release.