Skip to content

Remove implicit system crypto forcing on s390x - #567

Open
surenderky wants to merge 1 commit into
proxy-wasm:mainfrom
surenderky:s390x-remove-crypto-forcing
Open

surenderky wants to merge 1 commit into
proxy-wasm:mainfrom
surenderky:s390x-remove-crypto-forcing

Conversation

@surenderky

Copy link
Copy Markdown

PR #220 added a cpu=s390x arm to crypto_system so s390x builds automatically use the system crypto library, since BoringSSL doesn't build on s390x.

Because the arm keys on CPU it forces the -lcrypto path on s390x before any explicit crypto selection is considered, so a consumer that redirects the default crypto dependency can't opt out.

Several CI jobs already select system crypto explicitly with --define=crypto=system the s390x job was the only one relying on the implicit cpu arm. This removes the arm and updates the s390x job to pass --define=crypto=system, making crypto selection explicit and consistent across the matrix.

Fixes Issue #566

Signed-off-by: Surender Yadav <surender.yadav1@ibm.com>
@google-cla

google-cla Bot commented Sep 17, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@leonm1

leonm1 commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Hey @surenderky, thank you for the detailed issue report and PR. I can't legally look at the code until you sign the CLA -- can you take a look at the failing gh actions cla/google check?

@surenderky

Copy link
Copy Markdown
Author

Hey @surenderky, thank you for the detailed issue report and PR. I can't legally look at the code until you sign the CLA -- can you take a look at the failing gh actions cla/google check?

Hi @leonm1 the CLA authorization is in process and currently pending with our CLA managers, should be done by today.

@surenderky

Copy link
Copy Markdown
Author

Hi @leonm1 , I have got the CLA authorisation done. could you please review now?

@PiotrSikora

Copy link
Copy Markdown
Member

@surenderky this only changes the default crypto option on s390x back to BoringSSL, which as you noted doesn't work on s390x, so the only thing it does is breaking builds without explicit crypto=system selection.

@leonm1 / @mpwarres could you fix the Zizmor, whatever it is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants