Skip to content

Fix crowded header with a More overflow menu #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Sep 13, 2026
Merged

Fix crowded header with a More overflow menu #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 111 additions & 3 deletions src/components/Header.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@

.logo {
display: inline-flex;
flex-shrink: 0;
align-items: center;
gap: 0.8rem;
font-weight: 800;
font-size: 1.6rem;
letter-spacing: -0.01em;
white-space: nowrap;
}

.navDesktop {
Expand All @@ -31,25 +33,102 @@
font-size: 1.45rem;
font-weight: 600;
color: var(--text-muted);
white-space: nowrap;
}

.navDesktop a:hover {
.navDesktop a:hover,
.moreButton:hover,
.moreButton[aria-expanded='true'] {
color: var(--text);
}

.header a:focus-visible,
.header button:focus-visible {
outline: 2px solid var(--crest);
outline-offset: 4px;
border-radius: 4px;
}

.overflow {
position: relative;
}

.moreButton {
display: inline-flex;
align-items: center;
gap: 0.6rem;
min-height: 44px;
border: 0;
background: none;
color: inherit;
font: inherit;
cursor: pointer;
}

.moreButton[aria-expanded='true'] .chevron {
transform: rotate(180deg);
}

.dropdown {
position: absolute;
top: calc(100% + 1.2rem);
right: 0;
display: flex;
flex-direction: column;
min-width: 22rem;
max-height: calc(100dvh - 8rem);
overflow-y: auto;
overscroll-behavior: contain;
padding: 0.8rem;
background: var(--bg-elev);
border: 1px solid var(--border);
border-radius: var(--radius);
box-shadow: var(--shadow);
}

.dropdown a,
.mobile a {
display: flex;
align-items: center;
min-height: 44px;
padding: 0.9rem 1.2rem;
border-radius: 6px;
}

.dropdown a:hover,
.dropdown a:focus-visible,
.mobile a:not(:global(.btn-primary)):hover,
.mobile a:not(:global(.btn-primary)):focus-visible {
background: var(--bg-elev-2);
color: var(--text);
}

.dropdown .github {
justify-content: space-between;
margin-top: 0.6rem;
border-top: 1px solid var(--border-soft);
border-radius: 0 0 6px 6px;
}

.actions {
display: flex;
flex-shrink: 0;
align-items: center;
}

.hamburger {
display: none;
flex-shrink: 0;
flex-direction: column;
align-items: center;
justify-content: center;
gap: 4px;
background: none;
border: none;
cursor: pointer;
padding: 0.6rem;
width: 44px;
height: 44px;
}

.hamburger span {
Expand All @@ -59,17 +138,46 @@
border-radius: 2px;
}

.hamburger[aria-expanded='true'] span:first-child {
transform: translateY(6px) rotate(45deg);
}

.hamburger[aria-expanded='true'] span:nth-child(2) {
opacity: 0;
}

.hamburger[aria-expanded='true'] span:last-child {
transform: translateY(-6px) rotate(-45deg);
}

.mobile {
position: absolute;
top: 100%;
left: 0;
right: 0;
display: none;
flex-direction: column;
gap: 1.6rem;
padding: 2rem 2.4rem 2.6rem;
gap: 0.4rem;
max-height: calc(100dvh - 6.8rem);
overflow-y: auto;
overscroll-behavior: contain;
padding: 1.2rem 1.8rem 1.8rem;
background: var(--bg-elev);
border-bottom: 1px solid var(--border-soft);
font-size: 1.6rem;
font-weight: 600;
box-shadow: var(--shadow);
}

.dropdown[hidden],
.mobile[hidden] {
display: none;
}

@media (max-width: 880px) {
.inner {
gap: 1.2rem;
}
.navDesktop,
.actions {
display: none;
Expand Down
106 changes: 85 additions & 21 deletions src/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,113 @@
'use client';
import { useState } from 'react';
import { useEffect, useRef, useState } from 'react';
import Link from 'next/link';
import { nav, site } from '@/data/site';
import styles from './Header.module.css';

const primaryPaths: readonly string[] = ['/cards', '/collect', '/contribute'];
const primaryNav = nav.filter((item) => primaryPaths.includes(item.href));
const overflowNav = nav.filter((item) => !primaryPaths.includes(item.href));

export default function Header() {
const [open, setOpen] = useState(false);
const [menu, setMenu] = useState<'more' | 'mobile' | null>(null);
const headerRef = useRef<HTMLElement>(null);
const overflowRef = useRef<HTMLDivElement>(null);
const moreButtonRef = useRef<HTMLButtonElement>(null);
const mobileButtonRef = useRef<HTMLButtonElement>(null);

useEffect(() => {
if (!menu) return;

function dismissOutside(event: Event) {
const container = menu === 'more' ? overflowRef.current : headerRef.current;
if (event.target instanceof Node && !container?.contains(event.target)) {
setMenu(null);
}
}

function dismissOnEscape(event: KeyboardEvent) {
if (event.key !== 'Escape') return;
event.preventDefault();
setMenu(null);
(menu === 'more' ? moreButtonRef : mobileButtonRef).current?.focus();
}

document.addEventListener('pointerdown', dismissOutside);
document.addEventListener('focusin', dismissOutside);
document.addEventListener('keydown', dismissOnEscape);
return () => {
document.removeEventListener('pointerdown', dismissOutside);
document.removeEventListener('focusin', dismissOutside);
document.removeEventListener('keydown', dismissOnEscape);
};
}, [menu]);

useEffect(() => {
const breakpoint = window.matchMedia('(max-width: 880px)');
const closeMenu = () => setMenu(null);
breakpoint.addEventListener('change', closeMenu);
return () => breakpoint.removeEventListener('change', closeMenu);
}, []);

return (
<header className={styles.header}>
<header ref={headerRef} className={styles.header}>
<div className={`container ${styles.inner}`}>
<Link href="/" className={styles.logo} onClick={() => setOpen(false)}>
<Link href="/" className={styles.logo} onClick={() => setMenu(null)}>
<img src="/favicon.png" alt="" width={28} height={28} />
<span>Open Source Legends</span>
</Link>

<nav className={styles.navDesktop}>
{nav.map((n) => (
<Link key={n.href} href={n.href}>{n.label}</Link>
<nav className={styles.navDesktop} aria-label="Main navigation">
{primaryNav.map((n) => (
<Link key={n.href} href={n.href} onClick={() => setMenu(null)}>{n.label}</Link>
))}
<a href={site.github} target="_blank" rel="noreferrer">GitHub</a>
<div ref={overflowRef} className={styles.overflow}>
<button
ref={moreButtonRef}
type="button"
className={styles.moreButton}
onClick={() => setMenu(menu === 'more' ? null : 'more')}
aria-expanded={menu === 'more'}
aria-controls="overflow-navigation"
>
More
<svg className={styles.chevron} width="14" height="14" viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" aria-hidden="true">
<path d="m6 9 6 6 6-6" />
</svg>
</button>
<div id="overflow-navigation" className={styles.dropdown} hidden={menu !== 'more'}>
{overflowNav.map((n) => (
<Link key={n.href} href={n.href} onClick={() => setMenu(null)}>{n.label}</Link>
))}
<a className={styles.github} href={site.github} target="_blank" rel="noreferrer" onClick={() => setMenu(null)}>GitHub <span aria-hidden="true">↗</span></a>
</div>
</div>
</nav>

<div className={styles.actions}>
<Link href="/collect" className="btn-primary">Get a pack</Link>
<Link href="/collect" className="btn-primary" onClick={() => setMenu(null)}>Get a pack</Link>
</div>

<button
ref={mobileButtonRef}
type="button"
className={styles.hamburger}
onClick={() => setOpen(!open)}
aria-label="Toggle menu"
aria-expanded={open}
onClick={() => setMenu(menu === 'mobile' ? null : 'mobile')}
aria-label={menu === 'mobile' ? 'Close menu' : 'Open menu'}
aria-expanded={menu === 'mobile'}
aria-controls="mobile-navigation"
>
<span /><span /><span />
</button>
</div>

{open && (
<nav className={styles.mobile}>
{nav.map((n) => (
<Link key={n.href} href={n.href} onClick={() => setOpen(false)}>{n.label}</Link>
))}
<a href={site.github} target="_blank" rel="noreferrer">GitHub</a>
<Link href="/collect" className="btn-primary" onClick={() => setOpen(false)}>Get a pack</Link>
</nav>
)}
<nav id="mobile-navigation" className={styles.mobile} aria-label="Main navigation" hidden={menu !== 'mobile'}>
{nav.map((n) => (
<Link key={n.href} href={n.href} onClick={() => setMenu(null)}>{n.label}</Link>
))}
<a href={site.github} target="_blank" rel="noreferrer" onClick={() => setMenu(null)}>GitHub</a>
<Link href="/collect" className="btn-primary" onClick={() => setMenu(null)}>Get a pack</Link>
</nav>
</header>
);
}
Loading