Repository navigation
Systematic: shell syntax in git.run() calls across 8+ tools #172
Description
Problem
run() in lib/git.ts uses execFileSync('git', args) — no shell interpretation. But many tools pass strings containing shell operators that silently break:
2>/dev/null— passed as literal git args|| fallback— not executed, literal args| tail -1/| grep— literal args&& git commit— literal args< file— literal argsgit diff ...— becomesgit git diff ...
Already fixed
- clarify-intent (fix: clarify_intent non-git commands silently broken via git.run() #170)
- checkpoint, what-changed, session-health (fix: broken shell syntax in git.run() calls (checkpoint, what-changed, session-health) #171)
Still broken
| Tool | Line(s) | Shell syntax used |
|---|---|---|
| verify-completion | 37, 58, 83, 115, 133 | cat, pipe, 2>/dev/null, npm run build via git |
| token-audit | 42-43, 66, 83, 142 | 2>/dev/null, wc -l <, tail -c |
| session-handoff | 11, 47 | command -v, gh pr list ... || echo |
| audit-workspace | 39, 78 | 2>/dev/null, find ... | wc -l |
| sharpen-followup | 90 | 2>/dev/null |
| scope-work | 131 | git ls-files | head | grep |
| enrich-agent-task | 32-56 | 2>/dev/null, head -30, grep pipes |
| sequence-tasks | 93 | 2>/dev/null |
Fix approach
For each tool:
- Replace shell-piped commands with array-arg
run()calls - Do filtering/piping in JS (split, filter, slice)
- For non-git commands (
wc,find,cat), use Node.js fs/child_process directly - Remove
2>/dev/null—run()already catches errors gracefully
Activity
fix: replace shell syntax in run() calls across 8 tools (#172)
fix: replace shell syntax in run() calls across 8 tools (#172)
fix: replace shell syntax in run() calls across 6 tools (#172)
fix: replace shell syntax in run() calls across 5 tools (#172)
fix: replace shell syntax in git.run() calls across 10 tools (#172)
fix: replace shell syntax in run() calls across 8 tools (#172)
fix: remove shell syntax from git.run() calls in 5 tools (#172)
fix: remove shell syntax from verify-completion, token-audit, enrich-…
fix: bin entry now auto-detects TTY vs MCP server mode (#172)
fix: remove remaining shell syntax from git.run() in scope-work, what…
fix: remove shell syntax from git.run() calls across 8 tools (#172)
fix: replace shell syntax in run() calls across 8 tools (#172)
fix: eliminate shell syntax in git.run() calls across 8 tools (#172)
fix: replace shell syntax in git.run() calls across 8 tools (#172)
4 remaining items
fix: replace shell syntax in run() calls across all 8 remaining tools
fix(token-audit): replace shell syntax in run() calls with Node.js APIs
fix(session-handoff,sharpen-followup,sequence-tasks): replace shell s…
fix: replace shell syntax in run() calls across 4 tools (#172)
fix: eliminate shell syntax in git.run() calls across 8 tools (#172)
fix: replace shell syntax in git.run() with shell() helper across 8 t…
fix: replace shell syntax in run() calls across 8 tools
fix: replace shell syntax in run() calls across 8 tools (#172)
fix: replace shell syntax in run() calls with array args or shell()
fix(#172): replace shell() with Node.js APIs in audit-workspace and s…
fix(#172): replace shell syntax in enrich-agent-task and token-audit …
fix: replace shell syntax in run() calls across 8 tools
fix: replace shell syntax in run() calls across 8 tools (#172)
TerminalGravity commentedon Mar 10, 2026
Fixed in 3b855be (already on main). Closed 4 stale duplicate PRs.