Repository navigation
Widespread shell syntax in run() calls after execFileSync migration #110
Description
Problem
run() in src/lib/git.ts uses execFileSync (no shell), but many tool files still pass shell syntax that silently breaks:
- Shell operators:
||,&&,| - Redirects:
2>/dev/null,2>&1 - Prefixing
gitin strings (becomes a literal arg sinceexecFileSync('git', ['git', ...])) - Shell quoting/escaping
Affected files
PR #109 fixes 3 files. These still need fixing:
verify-completion.ts—cat,tsc --noEmit 2>&1 | tail,npm run build 2>&1 | tailtoken-audit.ts—wc -l,wc -c,tail -c,2>/dev/nullclarify-intent.ts—tsc --noEmit 2>&1 | grep,find ... | headsession-handoff.ts—command -v,gh pr list ... || echoaudit-workspace.ts—find ... | wc -l,2>/dev/nullenrich-agent-task.ts—git ls-files | grep,head -30scope-work.ts—git ls-files | head | grepsequence-tasks.ts—git ls-files | head
Options
- Fix each caller to use array args + JS logic (like PR fix: shell syntax bugs in what-changed, checkpoint, session-health #109)
- Add a
shell()helper that usesexecSyncfor commands that genuinely need shell features - Both — array args where simple,
shell()for complex piping
Option 3 is probably best. Some commands (find | grep | head) are genuinely easier with shell.
Activity
fix: resolve shell syntax in run() calls across all tool files
fix: replace shell syntax in run() calls with shell() helper or Node.…
fix(tools): replace shell syntax in run() calls with shell()/exec()/a…
TerminalGravity commentedon Mar 5, 2026
PR #113 covers all the files listed here with a clean three-tier approach: array args for simple git commands,
shell()for genuine pipe/redirect needs, andexec()for non-git binaries. Once that lands, the older fix PRs (#109, #111, #112, #101, #100) can be closed.One thing to watch: the
shell()helper defaults to a 10s timeout which might be tight for type-checking larger projects. Easy fix if it comes up.fix: resolve shell syntax in run() calls after execFileSync migration
fix: resolve shell syntax in run() calls across all tools (#110)
fix: resolve shell syntax in run() calls after execFileSync migration
fix: replace broken shell syntax in run() calls with shell() helper o…
fix: replace shell syntax in run() calls with array args (#110)
TerminalGravity commentedon Mar 5, 2026
Quick status check on the competing fix PRs:
Recommendation: merge #120 (once CI passes) since it builds on #109's approach and the JS replacements are solid. Then close #116 and #119 as superseded. The Option 3 approach (array args where simple, shell helper for complex piping) is the right call — some of those
find | grep | headchains really are easier with shell.fix: add shell() helper, fix remaining shell syntax in run() calls
fix: replace shell syntax in run() calls with shell() helper (#110)
fix: shell syntax bugs in 8 remaining tool files (#110)
fix: migrate shell syntax from run() to shell() helper across 8 tool …
fix: replace remaining run() calls using shell syntax with shell()
fix: add shell() helper and fix shell syntax in run() calls across 12…
TerminalGravity commentedon Mar 5, 2026
All files listed here are already using the
shell()helper fromsrc/lib/shell.ts. No remainingrun()calls with shell syntax. This was resolved alongside PR #109.fix: use canonical shellEscape from lib/shell.ts in enrich-agent-task…