Skip to content

[Feat] Show target instance before deploy, stop, destroy and compact - #64

Merged
bean1352 merged 7 commits into
mainfrom
feat/show-target-instance
Sep 17, 2026
Merged

bean1352 merged 7 commits into
mainfrom
feat/show-target-instance

Conversation

@bean1352

@bean1352 bean1352 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

What

Prints the resolved instance name and IDs before deploy, deploy sync-config, deploy service-config, stop, destroy and compact do anything, so you can see which instance is about to change. status prints the target first as well, with the API URL for self-hosted instances. JSON and YAML output are unchanged.

deploy and deploy service-config also warn when service.yaml has a different name than the instance, because deploying renames it.

Dry run

All deploy commands accept --dry-run. It prints the target instance, runs the validations, and stops before deploying or provisioning. It also shows what would change:

  • a diff of the local sync config against the deployed one
  • the service config sections that differ, by name only, so no values or secrets end up in a log

When the instance is deprovisioned, a real deploy provisions it first. The dry run says so and skips the sync config validation that needs a running instance.

stop and destroy already require --confirm=yes, so they are unchanged.

Notes

  • Adds diff (jsdiff) as a direct dependency of the CLI. It was already in the lockfile as a transitive dependency.
  • Connections that pass a password with secret: !env ... always show replication as changed, because the value is sent again. This is documented in the usage docs.

AI disclosure

I used Claude to research the codebase and implement the change. I reviewed and tested it myself.

@bean1352 bean1352 changed the title show target instance before deploy, stop, destroy and compact [Feat] Show target instance before deploy, stop, destroy and compact Sep 2, 2026
@bean1352
bean1352 marked this pull request as draft September 2, 2026 12:19
@bean1352
bean1352 requested a review from LucDeCaf September 2, 2026 12:38
@bean1352
bean1352 marked this pull request as ready for review September 2, 2026 12:38
LucDeCaf
LucDeCaf previously approved these changes Sep 2, 2026

@LucDeCaf LucDeCaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea, looks good 👍

Comment thread cli/src/commands/deploy/index.ts
LucDeCaf
LucDeCaf previously approved these changes Sep 3, 2026

@LucDeCaf LucDeCaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on my side, looks good

@bean1352
bean1352 force-pushed the feat/show-target-instance branch from e54b0cd to 771ec23 Compare September 16, 2026 10:26
@bean1352
bean1352 requested a review from LucDeCaf September 16, 2026 10:47
@bean1352
bean1352 merged commit 9196cb2 into main Sep 17, 2026
6 checks passed
@bean1352
bean1352 deleted the feat/show-target-instance branch September 17, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants