Repository navigation
refactor(puller)!: Replace report filters with explicit targets - #966
Merged
Merged
Conversation
Broadcast reports directly to target actors and update preprocessor binding to preserve destinations without affecting other pullers. BREAKING CHANGE: `PullerActor`, `PullerState`, `DatabasePollerThread`, and `PullerGenerator` now accept target_actors instead of report_filter.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 87.11% 87.76% +0.65%
==========================================
Files 80 78 -2
Lines 2887 2853 -34
==========================================
- Hits 2515 2504 -11
+ Misses 372 349 -23
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
ReportFilterfeature from thePullerActorand replaces it by a list of actors proxy.Report filtering should now be done in
ProcessororDispatchRuleinstead.Breaking changes:
powerapi.filterpackage.report_filter: ReportFilterwithtarget_actors: list[ActorProxy]inPullerActor,PullerState,DatabasePollerThread, andPullerGenerator