fix: Fix system packages

.gitignore

@@ -12,3 +12,5 @@ features/src/**/installer_*
 
 # Cache for prepared and cleaned feature for packaging/publishing
 .prepared-feature/
+
+.devcontainer/devcontainer-lock.json

features/src/system-packages/README.md

@@ -6,7 +6,7 @@ Install arbitrary system packages using the system package manager.
 
 ```json
 "features": {
-    "ghcr.io/postfinance/devcontainer-features/system-packages:1.0.0": {
+    "ghcr.io/postfinance/devcontainer-features/system-packages:1.0.1": {
         "packages": ""
     }
 }

features/src/system-packages/devcontainer-feature.json

@@ -1,6 +1,6 @@
 {
   "id": "system-packages",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "name": "System Packages",
   "description": "Install arbitrary system packages using the system package manager.",
   "options": {
@@ -14,4 +14,4 @@
       "default": ""
     }
   }
-}
+}

installer/system.go

@@ -107,28 +107,26 @@ func (s *system) OsInfo() *OsInfo {
 		if err := scanner.Err(); err != nil {
 			return
 		}
+		// We do not know which values are provided by the OS, so we take what
+		// we can get and set undefined values to "unknown"
 		vendor, ok := infoMap["ID"]
 		if !ok {
-			return
+			vendor = "unknown"
 		}
 		codename, ok := infoMap["VERSION_CODENAME"]
 		if !ok {
-			return
+			codename = "unknown"
 		}
 		versionId, ok := infoMap["VERSION_ID"]
 		if !ok {
-			return
+			versionId = "unknown"
 		}
 		s.osInfo = &OsInfo{
 			Vendor:    vendor,
 			Codename:  codename,
 			VersionId: versionId,
 		}
 	})
-	if s.osInfo == nil {
-		// Fill with unknown if we couldn't read the OS info
-		s.osInfo = &OsInfo{Vendor: "unknown", Codename: "unknown", VersionId: "unknown"}
-	}
 	return s.osInfo
 }