Skip to content

fix: patch vulnerabilities and bump outdated dependencies - #7664

Open
waldekmastykarz wants to merge 5 commits into
pnp:mainfrom
waldekmastykarz:patch-dependencies
Open

waldekmastykarz wants to merge 5 commits into
pnp:mainfrom
waldekmastykarz:patch-dependencies

Conversation

@waldekmastykarz

Copy link
Copy Markdown
Member

Pull Request Title

fix: patch vulnerabilities and bump outdated dependencies

Linked Issue

Supersedes #7663.

One PR = One Commit

This replacement carries forward both complete commits from #7663 and adds the newly cooldown-eligible security and dependency updates.

New Command = Five Files

N/A. This PR updates dependencies and the existing Zod compatibility helper only.

Main Branch Only

Targets upstream main.

Merge Conflicts

The branch is based on the latest upstream main.

Summary

Security status

npm audit reports three remaining entries:

  • high-severity node-forge advisory: 1.4.0 is the latest published version and npm reports no fix available
  • low-severity serialize-javascript advisory through mocha: the fixed 7.1.3 release is not published; 7.1.2 is the latest registry version
  • mocha is reported because it depends on the affected serialize-javascript; npm's suggested forced downgrade to Mocha 7.2.0 does not provide a published fixed dependency

Cooling down

  • @azure/msal-common 16.14.3 — eligible 2026-10-28 19:12 UTC
  • @azure/msal-node 7.1.1 — eligible 2026-10-28 19:21 UTC; this PR uses eligible fixed version 7.1.0
  • @azure/msal-node-extensions 5.5.3 — eligible 2026-10-28 19:14 UTC

Not auto-applied

  • major direct updates: @types/node, eslint-plugin-mocha, mocha, and typescript
  • pre-release-only updates: @typescript-eslint/eslint-plugin and @typescript-eslint/parser
  • major override updates: @xmldom/xmldom, uuid, swiper, diff, and jws

Validation

  • npm run build — passed
  • npm test — passed
  • 16,263 tests passing
  • 100% statement, branch, function, and line coverage
  • final npm audit — one high and two low entries remain, all currently unpatchable
  • final npm outdated — all remaining compatible updates are in cooldown
  • final override scan — patch/minor overrides are current; only major updates remain

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 793232e7-059b-4240-ae2b-03e3eefb236b
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 158b7bc2-4690-4b5c-b369-7bf185f5f787
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 36e833d5-8958-455d-8460-05c22e2e3185
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 36e833d5-8958-455d-8460-05c22e2e3185

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The nullable-schema test checks only the option name, so it would miss a regression in the inferred option type that controls argument parsing.

1 open issue
1 file not reviewed
  • npm-shrinkwrap.json: Generated file
What changed in this PR

This PR carries forward #7663’s dependency refresh for CLI for Microsoft 365, adds security updates that have cleared the seven-day cooldown, and preserves the Zod compatibility adjustment.

Changes:

  • Updates runtime dependencies, development tooling, and selected overrides.
  • Refreshes locked dependencies, including MSAL Node and Undici security updates.
  • Handles array-valued JSON Schema types when inferring CLI option types.
File Description
src/​utils/​zod.ts Normalizes array-valued schema types before selecting an option parser.
package.json Updates dependency ranges and security-related overrides.
npm-shrinkwrap.json Locks updated direct and transitive dependencies and their metadata.

Review effort: Balanced

Comment thread src/utils/zod.ts
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The MSAL 5.6.0→7.1.0 upgrade requires maintainer validation of live login, token refresh, and persisted/native cache compatibility across supported platforms because current tests stub token acquisition.

No open issues 🎉

1 resolved since last review
1 file not reviewed
  • npm-shrinkwrap.json: Generated file

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants