Repository navigation
CR-150 BATCH2: L19e + L19h + L15b (admission journal window, bracket roster parking, native bar views) - #441
Merged
Conversation
Implement the frozen ee3083d V1/V2 contract and the 19:24 eager-component ruling. Preserve v3 layouts, owned fallbacks and digest bytes; add no borrowed production export or concrete lower provider. Update read-inventory claims introduced by d0fd21c and amended by a6abb14 and ee3083d; other documentation edits only carry source coordinates. Reword the EntryExitGuard explanation introduced by 47184e5 to include unconditional outer-run binding detachment. Red witness committed first as 100a605. Builds, compilation, tests and source guards were not run on this Mac, per CORE-TOP brief; lab verification remains pending.
Round 3 item 1, lab rj-20261018t115236-b4aba1: repair the shared source line introduced by 2539102 so the detached-comment reader sees separate translation units. Carry every affected root-CMake documentation coordinate by one line; tests/CMakeLists.txt and its private_fixture_reads.evidence pin stay unchanged, following the line-pin discipline of P00 fix4 (25e4491). The documentation source claims came from 47184e5 and 868aa65; only their coordinates change. No builds, tests or guards executed on the Mac.
Round 3 item 2, lab rj-20261018t115236-b4aba1: carry 302 source-coordinate spans from ee3083d to the unchanged 2539102 engine sources, including all 288 anchors listed in lab-doc-anchors.log and 14 additional affected references. Handle basenames, full paths and shorthand lists while retaining the backticked claims and the intended occurrence of repeated symbols. Preserve citations already moved in Round 2. Doc source-claim provenance: 47184e5, 65c69b0, f48b7c8 and 868aa65. Only citation coordinates change; no policy, numeric assertion, frozen declaration or engine behavior is reworded. Repair source drift introduced by 2539102. No builds, compilation, tests or guards executed here. CORE-TOP must rerun the two failed preflight stages and required verification on the lab.
Round 4, lab rj-20261018t124444-007ef1: update only NativeFxCurveVersions.test_new_paths_append_without_reindexing_existing_pins. Retain FX at FILES[12:14], the identity pin at 11 and both uniqueness checks; expect the seven L15a paths in FILES[14:]. Comparison with core/cr150-p00-contracts (ee3083d) confirms its full 14-entry FILES prefix is already unchanged, so do not reorder or rewrite the guard list. Follow the FX append precedent from e7cdf05 without preserving its stale newest-tail assertion. No build, compilation, test or guard executed here.
Remove only the out-of-contract final recorded-row/scalar CHECK, its sole stderr diagnostic, and the now-unused cinttypes include. Preserve every other CHECK and all runtime/hash recording cadence. Base evidence quoted in REPORT.md Fix rounds 2-4: Round-2 Debug ctest.log:1863-1864 and Release ctest.log:1866-1867, rj-20261018t173132-91c857: "hash boundary: recorded=4c5b127f7df116d4 scalar_after_run=9718642416a18a0b scalar_after_report=9718642416a18a0b" "whole.broker_state_hash[63] == on.broker_state_hash()" These observations already differed before F0a. CORE-TOP ruling 09:48, option (a), excludes cadence changes from CR-150 and authorizes removing this one assertion.
Keep tests/CMakeLists.txt and the L7a/L7b/L0b files byte-identical to integration 5be8c54. Register the admission-window unit in its own lane file with the original PINEFORGE_BUILD_SOURCE_LAYER guard. Preserve the prior F0a runtime and both adapter witnesses.
…j-20261019t010941-4bc9d7
…e (CR150-CX round m10)
The l19e-m10 doc-anchors log identifies the sole stale citation at native-feature-parity.md:1839. PineExecutionAdapter::on_applied starts at pine_adapter.cpp:24410 after the 16-line F0a insertion. Change only 24394 to 24410; preserve the row and all code/tests.
…e (CR150-CX, no file overlap)
…h (CR150-CX, no file overlap)
… citations refreshed; code unchanged
…ns refreshed; code unchanged
…ns and c_abi.cpp content hashes refreshed; code unchanged
…onflict blocks), citations refreshed; code unchanged Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tions refreshed; scripts/broker_state_hash_waivers.txt, scripts/check_c_abi_runtime.py, scripts/test_ci_verify.py combined (public C ABI declarations 104, runtime implementations 84) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…sign/cr150-contracts.md resolved (both lanes' rows kept; native_run_spec_digest coordinates from L17a's side); code unchanged Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
luisleo526
marked this pull request as ready for review
October 19, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CR-150 integration lanes L19e (3bdc2db), L19h (2dc35f0) and L15b (5e412f1), merged as one batch onto integration 39a718b.
Proof: squash proof 0b79b501d (single parent 39a718b, tree = this head 89c3724), lab job rj-20261019t075150-df09fd: preflight, release, debug, docs exit 0; ctest 100% (979 Release, 960 Debug); by name in Release and Debug: test_admission_journal_window (L19e), test_native_bar_views_l15b + l15a + guard_l15a (L15b), test_bracket_roster_parking (L19h), test_cr150_cmake_d and its controls.
Doc-revert lineage named in the squash: 0d8b203, 70ddaa3 (L15b) and 4c78f39 (L6b lineage).
Merge order: after L17a (#432); the two share docs/design/cr150-contracts.md only (docs conflict), so this branch gets a docs re-merge onto the new head before merging.
🤖 Generated with Claude Code