Repository navigation
cr150 L15a: bar views staging, accessor and guard (no caller yet) - #418
Merged
Merged
Conversation
Apply the CORE-TOP rev 6 amendment recorded at 10-18 19:24: adopt the V1/V2 proposal with all nine required changes and the eager-at-configure component-digest ruling. Supersede OPEN/forward-only prose from d0fd21c, 54acd1c, 9f01fbc and a6abb14. Refresh the scope wording from 57857a5 and extend the source inventory from 131852f with projection validation. Freeze declarations and contracts only: pending staging and active query on the private consumer, explicit feed context/accessor, four-operation provider, and static assertions. Existing execution paths and CMake line pins are unchanged.
Implement the frozen ee3083d V1/V2 contract and the 19:24 eager-component ruling. Preserve v3 layouts, owned fallbacks and digest bytes; add no borrowed production export or concrete lower provider. Update read-inventory claims introduced by d0fd21c and amended by a6abb14 and ee3083d; other documentation edits only carry source coordinates. Reword the EntryExitGuard explanation introduced by 47184e5 to include unconditional outer-run binding detachment. Red witness committed first as 100a605. Builds, compilation, tests and source guards were not run on this Mac, per CORE-TOP brief; lab verification remains pending.
Round 3 item 1, lab rj-20261018t115236-b4aba1: repair the shared source line introduced by 2539102 so the detached-comment reader sees separate translation units. Carry every affected root-CMake documentation coordinate by one line; tests/CMakeLists.txt and its private_fixture_reads.evidence pin stay unchanged, following the line-pin discipline of P00 fix4 (25e4491). The documentation source claims came from 47184e5 and 868aa65; only their coordinates change. No builds, tests or guards executed on the Mac.
Round 3 item 2, lab rj-20261018t115236-b4aba1: carry 302 source-coordinate spans from ee3083d to the unchanged 2539102 engine sources, including all 288 anchors listed in lab-doc-anchors.log and 14 additional affected references. Handle basenames, full paths and shorthand lists while retaining the backticked claims and the intended occurrence of repeated symbols. Preserve citations already moved in Round 2. Doc source-claim provenance: 47184e5, 65c69b0, f48b7c8 and 868aa65. Only citation coordinates change; no policy, numeric assertion, frozen declaration or engine behavior is reworded. Repair source drift introduced by 2539102. No builds, compilation, tests or guards executed here. CORE-TOP must rerun the two failed preflight stages and required verification on the lab.
Round 4, lab rj-20261018t124444-007ef1: update only NativeFxCurveVersions.test_new_paths_append_without_reindexing_existing_pins. Retain FX at FILES[12:14], the identity pin at 11 and both uniqueness checks; expect the seven L15a paths in FILES[14:]. Comparison with core/cr150-p00-contracts (ee3083d) confirms its full 14-entry FILES prefix is already unchanged, so do not reorder or rewrite the guard list. Follow the FX append precedent from e7cdf05 without preserving its stale newest-tail assertion. No build, compilation, test or guard executed here.
luisleo526
marked this pull request as ready for review
October 18, 2026 15:20
luisleo526
added a commit
that referenced
this pull request
Oct 18, 2026
CR150-CX for CORE-TOP: merge 0faaf06 (L8a #419 on L15a #418) into the accepted L16 head without rewriting history. Preserve the accepted lower-path provider and its guard unchanged, and retain the integration TradeLedger implementation and helper adaptations. Resolve both CMake tail registrations after the private-fixture pins. Reconcile all six documentation conflicts against the merged source coordinates, including continuation ranges and the scheduler next_open; retain the integration symbol clarifications and trail-carry citations from 0faaf06. No tests, guards, builds or generators were executed locally. CORE-TOP owns exact-tree lab re-proof before merging PR #424.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CR-150 lane L15a, per DESIGN rev 6 §2.2 and its row, against the P00 contracts with the V1/V2 ruling (REVISION 19:24, nine required changes). The base is core/cr150-p00-contracts, so this diff shows L15a only.
Lab: rj-20261018t132735-88d3a3 green (preflight, release, debug, docs) on ddc9c94. The Fable gating read comes before merge. Not to merge before the 1.6.2-rc.1 cut, and only after #413.
🤖 Generated with Claude Code