Repository navigation
Remove null connection overrides next to url in the CI test config - #164
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused configuration cleanup resolves the compatibility conflict with no blocking issues identified.
No open issues 🎉
What changed in this PR
Updates the CI test database configuration for DoctrineBundle 3 compatibility.
Changes:
- Removes five null connection options that conflict with
url, leaving the DSN and mapping settings unchanged.
| File | Description |
|---|---|
.github/ci/files/config/packages/test/config.yaml |
Removes null host, port, database, user, and password overrides. |
Review effort: Balanced
DoctrineBundle 3 rejects host, port, dbname, user or password on a connection that also defines url, even when the values are null. Nothing in the CI setup sets those keys, so the lines have no effect on DoctrineBundle 2. Related: pimcore/platform-version#672 Co-Authored-By: Claude <noreply@anthropic.com>
mcop1
force-pushed
the
chore/doctrine-bundle-3-ci-config
branch
from
October 21, 2026 18:25
59b303f to
58e041d
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Related: pimcore/platform-version#672
Removes the
host,port,dbname,userandpassword: ~lines next tourlin.github/ci/files/config/packages/test/config.yaml.DoctrineBundle 3 rejects these keys on a connection that also defines
url, even when the values are null:pimcore/pimcore#19596 allows DoctrineBundle 3 in Pimcore 2026.4. Once it is merged, CI legs that install
pimcore/pimcore2026.x with the highest dependencies get DoctrineBundle 3, and the test kernel would no longer boot with these lines. Nothing in the CI setup sets those keys, so removing them has no effect on DoctrineBundle 2.Additional info
Changed by a script (same change in all affected repositories). The new config was checked against DoctrineBundle 3's configuration validation: the old file fails it, the new file passes.
🤖 Generated with Claude Code
Targets
2026.3: bundles that support PHP 8.5 run the2026.x-devCI legs on every branch, so the2026.3branch needs the change as well. It reaches2026.xwith the next forward merge.