Repository navigation
[Bug] Remove null connection overrides next to url in the test config (DoctrineBundle 3) - #299
Merged
Merged
Conversation
…rineBundle 3) DoctrineBundle 3 rejects host, port, dbname, user or password on a connection that also defines url, even when the values are null. Nothing sets those keys for the test connection, so dropping them has no effect on DoctrineBundle 2. Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
berfinyuksel
added
the
Skip Milestone Check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pimcore/pimcore#19596 (
2026.x, merged 2026-10-21) allows DoctrineBundle 3. This repository pinspimcore/pimcore: 2026.x-dev, so CI now resolvesdoctrine/doctrine-bundle3.3.3, whose configuration validation rejectshost,port,dbname,userorpasswordon a connection that also definesurl, even when the values are null (array_intersect_key, notisset):config/packages/test/config.yamlhas exactly that pattern, so the test kernel no longer boots:CliCommandTestfails on every run since DoctrineBundle 3 is resolved (first seen on #297, run 40673821870; the last green run on 2026-10-15 predates #19596). Core'sdefault.yamlonly setsurlfor the default connection, so the null overrides never did anything.Same change as pimcore/pimcore
1b64d9aand the bundle PRs tracked in pimcore/platform-version#673; demo-enterprise gets it in pimcore/demo-enterprise#553.Changes
config/packages/test/config.yamlhost/port/dbname/user/password: ~next tourlVerification
Configuration::configureDbalDriverNode(): the old file fails theurlconflict check, the new one passes. No effect on DoctrineBundle 2.test-pimcore-skeleton, full install + Codeception) is the runtime check for this PR.🤖 Generated with Claude Code