Conversation
gosec's taint analysis flagged the unpack-directory removal and the app socket/manifest/.suspended stats added in #490. The removal only ever targets the os.MkdirTemp directory of a catalogue install; the others are stats of fixed names under the app directory the operator named. Annotate them the way the surrounding code does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
#490 merged with the (non-gating) gosec check reporting 5 new G703 "path traversal via taint" alerts in
cmd/pilotctl/appstore.go. None is exploitable; this annotates them with the reason, as the surrounding code does, so the scan is back to its baseline.Changes
os.RemoveAll(bundleDir)in install: for a catalogue installbundleDiris theos.MkdirTempdirectoryfetchAndUnpackBundlecreated, never a caller-supplied path.os.Statcalls inappstore call/waitForAppSocket: stats of fixed names (app.sock,manifest.json,.suspended) under the app directory the operator named; nothing is read or written.No behaviour change.
Test Plan
go build ./cmd/pilotctl/gosec -include=G703 ./cmd/pilotctl/: the five lines are no longer reported; the remaining findings are pre-existing🤖 Generated with Claude Code