Fix E2E failures on v2.x and with git 2.47+ - #1233
Merged
Merged
Conversation
The E2E tests fail for two unrelated reasons. On the v2.x branch, every test that installs composer fails, locally and in CI. The generated test project required phpro/grumphp as `dev-<branch>@dev`, but composer reads a version-like branch such as `v2.x` as `2.x-dev`, so the constraint never matched. PR builds run on a detached HEAD and fell back to the commit sha, which is why they kept passing. I replaced the constraint with `*@dev`. The path repository is canonical for phpro/grumphp, so this always resolves to the local checkout. The random failures on the macOS runners come from git 2.47+. There, a commit starts a detached auto maintenance process that creates and removes `.git/objects/maintenance.lock` after the commit has returned, and that races the recursive chmod in the test cleanup. `phpunit.xml.dist` now disables `maintenance.auto` through the `GIT_CONFIG_COUNT`/`KEY`/`VALUE` environment variables, which every git process spawned by the tests inherits. I could not reproduce this one locally on git 2.39, so CI is the real check.
Without an image, AppVeyor uses Windows Server 2012 R2. There, choco install vcredist140 (needed for PHP 8.4+) regularly fails the TLS handshake with download.visualstudio.microsoft.com ("Could not create SSL/TLS secure channel"), while the same URL downloads fine in other jobs. The Visual Studio 2022 image runs on Windows Server 2019, which has a newer TLS stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The E2E tests fail for two unrelated reasons.
On the v2.x branch, every test that installs composer fails, locally and in CI. The generated test project required phpro/grumphp as
dev-<branch>@dev, but composer reads a version-like branch such asv2.xas2.x-dev, so the constraint never matched. PR builds run on a detached HEAD and fell back to the commit sha, which is why they kept passing. I replaced the constraint with*@dev. The path repository is canonical for phpro/grumphp, so this always resolves to the local checkout.The random failures on the macOS runners come from git 2.47+. There, a commit starts a detached auto maintenance process that creates and removes
.git/objects/maintenance.lockafter the commit has returned, and that races the recursive chmod in the test cleanup.phpunit.xml.distnow disablesmaintenance.autothrough theGIT_CONFIG_COUNT/KEY/VALUEenvironment variables, which every git process spawned by the tests inherits. I could not reproduce this one locally on git 2.39, so CI is the real check.