feat(phplint): add php_executable option for parallel-lint configuration - #1231
Merged
Merged
Conversation
Contributor
Author
|
The CI failure appears to be unrelated to this change. All other matrix jobs are green, and the failing tests are E2E tests rather than tests related to the PhpLint task. The stack trace also points to a filesystem/Git maintenance issue (maintenance.lock) during the E2E test cleanup rather than the modified code. |
Contributor
|
Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an optional
php_executableconfiguration option to thephplinttask.When configured, the task passes the value to
parallel-lintusing its native-poption. If omitted, the current behaviour is preserved.This makes it possible to explicitly select the PHP executable used by
parallel-lint, which is useful in environments where the default executable cannot be used reliably (for example, versioned PHP installations such as Laravel Herd).The change is fully backwards compatible and includes unit tests for the new configuration option.