ci: add PHP 8.6 to the test matrix - #681
Merged
Merged
Conversation
Run the test suite and the phar smoke tests on PHP 8.6 as well, on the same footing as every other supported version: a failure there fails the build. The build job installs with --ignore-platform-req=php+ because phpspec/prophecy enumerates the PHP versions it supports one by one (php 8.2.* || 8.3.* || 8.4.* || 8.5.*) rather than using a caret range, so composer cannot resolve on 8.6 at all without relaxing the upper platform bound. It is the only dependency that needs this, and it will keep needing it after 8.6 is released, until prophecy tags a version that lists 8.6. Marked fail-fast: false on smoke-test-phar, which had no such setting, so one version failing no longer cancels the others. Accept 8.6 as a --target-php-version too: without it, both jobs would fail outright, because TargetPhpVersion::create(null) defaults to the runtime version and rejects anything outside VALID_PHP_VERSIONS. nikic/php-parser's PhpVersion::fromString has no upper bound, so the parser handles the new target as is. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T7vgncWbVHuX6q61TZgtXM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
=========================================
Coverage 97.72% 97.72%
Complexity 767 767
=========================================
Files 102 102
Lines 2199 2199
=========================================
Hits 2149 2149
Misses 50 50
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the test suite and the phar smoke tests on PHP 8.6 as well, on the same footing as every other supported version: a failure there fails the build.
The build job installs with --ignore-platform-req=php+ because phpspec/prophecy enumerates the PHP versions it supports one by one (php 8.2.* || 8.3.* || 8.4.* || 8.5.*) rather than using a caret range, so composer cannot resolve on 8.6 at all without relaxing the upper platform bound. It is the only dependency that needs this, and it will keep needing it after 8.6 is released, until prophecy tags a version that lists 8.6.
Marked fail-fast: false on smoke-test-phar, which had no such setting, so one version failing no longer cancels the others.
Accept 8.6 as a --target-php-version too: without it, both jobs would fail outright, because TargetPhpVersion::create(null) defaults to the runtime version and rejects anything outside VALID_PHP_VERSIONS. nikic/php-parser's PhpVersion::fromString has no upper bound, so the parser handles the new target as is.