Repository navigation
Conversation
Static builds couldn't set Go linker variables such as EmbeddedAppPath, or add build tags, since static-php-cli generates the Go flags. Expose GO_BUILD_FLAGS, GO_LDFLAGS and GO_TAGS, forwarded to static-php-cli which merges them into its own flags, and document how to fix the embedded app extraction path.
Member
Author
|
Closing: static-php-cli already reads these settings from the environment (SPC_REGISTRIES, and SPC_CMD_VAR_FRANKENPHP_GO_* since crazywhalecc/static-php-cli#1269), and build-static.sh reuses dist/spc, so this isn't needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static builds couldn't set Go linker variables such as
EmbeddedAppPath, or add build tags, since static-php-cli generates the Go flags. This exposesGO_BUILD_FLAGS,GO_LDFLAGSandGO_TAGSinbuild-static.sh, forwarded to static-php-cli throughcraft.yml'sextra-envlikeXCADDY_ARGS, and documents how to fix the extraction path of embedded apps:EMBED=/path/to/app GO_LDFLAGS="-X github.com/dunglas/frankenphp.EmbeddedAppPath=/opt/my-app" ./build-static.shRequires crazywhalecc/static-php-cli#1269; older static-php-cli versions ignore these variables.