Repository navigation
Conversation
Unused ones are now a single info line. Fixes pgrundev#130.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130.
After an ICU upgrade on a libc database, every built-in *-x-icu collation
still records the old version, so collation_version_mismatch warned in every
database and listed all 871 of them. Nothing uses those collations, so nothing
can be out of order.
Now a changed collation only counts if a column, index, partition key or
something in pg_depend uses it. If nothing does, it's one info line that
doesn't affect the exit code. A used one still warns and the database default
is still critical.
One catch: Postgres doesn't record pg_depend rows for built-in collations
like PG16's unicode, so the query also checks pg_attribute and
pg_partitioned_table directly. The new integration test covers that case.
This adds an unreferenced field to the JSON, so the schema goes to 1.6.0.
I tested on PG 18.6 with all 871 ICU collations forced stale. Before: a warn
with 871 evidence lines. After: one info line. The full suite, doc-verify,
lint and gate.sh pass.