feat: UPDATE non-deterministic transaction-time rewrites - #1718
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
levkk
reviewed
Oct 2, 2026
| let conn = conn.get(1).unwrap(); | ||
|
|
||
| let row_created_at_before_time: DateTime<Utc> = { | ||
| conn.execute("TRUNCATE sharded").await.unwrap(); |
Collaborator
There was a problem hiding this comment.
Don't need to address this in this PR, but we should start writing tests in such a way so we can run them in parallel. Easiest way to do this is to create dedicated fixtures for each test; our config would allow this since we shard by column, not by table and as long as the table has a sharding key, it'll work.
levkk
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1713 to also handle re-writing UPDATE statements when a date-time function based on the transaction start time is present. Re-uses the same transform code as SELECT.