Skip to content

fix(deparse): deparse timezone with parentheses #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meskill wants to merge 2 commits into from
Closed

fix(deparse): deparse timezone with parentheses #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c92b4b
test: deparse timezone
meskill Sep 24, 2026
ebb4b03
fix(deparse): use fork
meskill Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
[submodule "libpg_query"]
path = libpg_query
url = https://github.com/pganalyze/libpg_query
# TODO: rollback to original repo after merge https://github.com/pganalyze/libpg_query/pull/368
url = https://github.com/meskill/libpg_query

@levkk levkk Sep 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's base this on our fork: https://github.com/pgdogdev/libpg_query/

branch = fix-at-time-paranses
2 changes: 1 addition & 1 deletion libpg_query
Open in desktop
Submodule libpg_query updated 5 files
+15 −4 scripts/pg_config_overrides.h
+15 −4 src/postgres/include/pg_config.h
+12 −1 src/postgres_deparse.c
+2 −0 test/deparse_tests.c
+34 −0 test/fuzz/fuzz_protobuf.c
7 changes: 7 additions & 0 deletions src/deparse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,11 @@ fn test_deparse() {
run_test("DELETE FROM users WHERE id = 1");
run_test("SET my_config TO 1");
run_test("TRUNCATE users");
run_test("SELECT ts AT TIME ZONE tz FROM s");
run_test("SELECT (ts -> 'a') AT TIME ZONE tz FROM s");
run_test("SELECT ts AT TIME ZONE (a -> 'b') FROM s");
run_test("SELECT ts AT TIME ZONE (tz || 'x') FROM s");
run_test(
"SELECT ((summary ->> 'ts')::timestamptz AT TIME ZONE ((summary -> 'stop') ->> 'tz'))::date AS d FROM s",
);
}
Loading