feat: support WAL PVC storage class selection - #144
Merged
Merged
Conversation
dkarter
marked this pull request as ready for review
September 29, 2026 19:00
levkk
reviewed
Sep 29, 2026
| exit 1 | ||
| fi | ||
|
|
||
| echo "" |
Contributor
There was a problem hiding this comment.
Same comment as last PR, let's stop adding tests here.
Contributor
Author
There was a problem hiding this comment.
oh my bad i missed the comment on the last pr!
levkk
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PgDog's WAL PVC currently inherits the cluster's default StorageClass. That can produce a disk the PgDog node pool cannot attach; for example, a
pd-balancedvolume on a C4A node that requires Hyperdisk.Summary of Changes
statefulSet.walPvc.storageClassNameto the StatefulSet claim template.Testing
./test/test.shpasses. To check the output, render withtest/values-statefulset-storage-class.yamland confirm thewalvolume claim template hasstorageClassName: balanced-storage. Render withtest/values-statefulset.yamland confirm it has nostorageClassNamefield.Dependencies/Special Considerations
This only affects newly created claims. Existing WAL PVCs keep their assigned StorageClass; check for outstanding prepared transactions before considering any PVC replacement.