Skip to content

feat: support WAL PVC storage class selection - #144

Merged
levkk merged 1 commit into
pgdogdev:mainfrom
dkarter:feat/wal-pvc-storage-class
Sep 29, 2026
Merged

levkk merged 1 commit into
pgdogdev:mainfrom
dkarter:feat/wal-pvc-storage-class

Conversation

@dkarter

@dkarter dkarter commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Motivation

PgDog's WAL PVC currently inherits the cluster's default StorageClass. That can produce a disk the PgDog node pool cannot attach; for example, a pd-balanced volume on a C4A node that requires Hyperdisk.

Summary of Changes

  • Add optional statefulSet.walPvc.storageClassName to the StatefulSet claim template.
  • Leave it unset by default so existing installs keep their current behavior. An explicit empty string disables dynamic provisioning, as in Kubernetes PVCs.
  • Add tests for omitted, named, and empty storage classes. Bump the chart to v0.83.

Testing

./test/test.sh passes. To check the output, render with test/values-statefulset-storage-class.yaml and confirm the wal volume claim template has storageClassName: balanced-storage. Render with test/values-statefulset.yaml and confirm it has no storageClassName field.

Dependencies/Special Considerations

This only affects newly created claims. Existing WAL PVCs keep their assigned StorageClass; check for outstanding prepared transactions before considering any PVC replacement.

@dkarter
dkarter marked this pull request as ready for review September 29, 2026 19:00
Comment thread test/test.sh
exit 1
fi

echo ""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as last PR, let's stop adding tests here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad i missed the comment on the last pr!

@levkk
levkk merged commit e79c468 into pgdogdev:main Sep 29, 2026
2 checks passed
@dkarter
dkarter deleted the feat/wal-pvc-storage-class branch September 29, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants