Repository navigation
Conversation
… a row. pgadmin-org#10602 The helper looked for a button inside [data-test="add-row"], but that attribute is on the button itself, so it clicked nothing. It now clicks the right element and asserts that the grid gained a row. That exposed two spec bugs: the primary key, unique constraint and foreign key specs shared one schema across tests, so fields mutated by the properties view leaked a helpMessage prop into later grid cells, and the partitions spec made the partition schema its own top schema, which has no session data.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe add-row helper now verifies that it adds one direct grid row. Schema UI test changes document existing per-test setup and create fresh schema objects in partition, primary-key, and unique-constraint cases. ChangesSchema UI Regression Tests
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly identifies the main change: fixing the Jest addNewDatagridRow helper so schema UI tests verify row creation. It is concise and directly related to the pull request. |
| Linked Issues check | |
Issue #10602 requires addNewDatagridRow to select the button, click it, and verify that one row was added. genericFunctions.jsx now selects [data-test="add-row"], asserts the button and containi… |
| Out of Scope Changes check | |
The changes stay within issue #10602. The row-count helper strengthens the required test behavior. The schema fixture and partition setup changes correct failures exposed by exercising that behavior. … |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 5… |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
Author
|
Squashed and merged as 1402f7d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addNewDatagridRowqueried[data-test="add-row"] button, butPgIconButtonputsdata-teston the<button>itself, so it matched nothing anduser.click(null)clickeddocument.body. The helper now clicks[data-test="add-row"], asserts the button exists, and asserts that the grid's own row count went up by one.Exercising the new-row path exposed two spec bugs, both fixed in the specs:
field.helpMessage = ''on the schema's fields, and that then reached a DOM element in the later grid cells, tripping theconsole.errorguard. Each test now gets a fresh schema, as each dialog does in the product.top, which never has session data, sotop.sessData.partition_typethrew. It now lets the collection become the top schema, as the table dialog does in the product.Test plan
npx jest regression/javascript/schema_ui_files regression/javascript/SchemaView: 80 suites, 475 tests passCloses #10602
Summary by CodeRabbit