Repository navigation
Conversation
…as two unrelated functions. pgadmin-org#10597 Schema Diff matched functions and procedures on a name that included their input argument names, so renaming an input argument produced a Source Only/Target Only pair, and the generated CREATE OR REPLACE was rejected by PostgreSQL before the old function was dropped. Functions and procedures are now matched on their name and input argument types, as PostgreSQL identifies them, whilst still being shown under their name with argument names (the source's, for a Different object). When the input argument names differ, the target is dropped and recreated from the source. Closes pgadmin-org#10597
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughSchema Diff now matches functions and procedures by name and input argument types, while displaying titles that include input argument names and exclude ChangesFunction and procedure signature matching
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant FunctionQueries
participant DirectoryCompare
participant FunctionComparison
participant SchemaDiffSQL
FunctionQueries->>DirectoryCompare: Return name and diff_key
DirectoryCompare->>FunctionComparison: Compare objects matched by diff_key
FunctionComparison->>SchemaDiffSQL: Drop and recreate when input argument names differ
Merge Risk: 🔵 Low · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly describes the main change: Schema Diff now matches functions correctly when an input argument is renamed. |
| Linked Issues check | |
Issue #10597 requires matching functions and procedures by name plus input argument types, reporting renamed input arguments as one Different object, and dropping the target before recreation when Pos… |
| Out of Scope Changes check | |
The changes stay within issue #10597. The PostgreSQL and EPAS templates implement the required matching key. The directory_compare title support enables the required display behavior. The function-n… |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 3 files. (4 skipped: 4… |
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
Author
|
Squashed and merged as 6594977. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema Diff matched functions and procedures on a name that included their input argument names, so renaming an input argument produced a Source Only/Target Only pair, and the generated
CREATE OR REPLACEwas rejected by PostgreSQL (cannot change name of input parameter) before the old function was dropped.oidvectortypes(proargtypes)), which is how PostgreSQL identifies them.directory_comparegains a small, generic way for a node to supply a display title separate from its match key; the title is never compared.The EPAS templates got the same change but are untested locally.
Test plan
tools.schema_diff.tests.test_schema_diff_function_signaturewith renamed IN and INOUT arguments, an unnamed-to-named argument and a renamed procedure argument; it checks the title, the DROP before CREATE, and that the target compares as Identical after the script is appliedtools.schema_diffpackage (9 tests) and the functions node package (78 tests) on PostgreSQL 18Closes #10597
Summary by CodeRabbit