chore(examples): fix broken scripts, remove dead ones, add README - #700
Open
karkikamal098 wants to merge 3 commits into
Open
karkikamal098 wants to merge 3 commits into
karkikamal098 wants to merge 3 commits into
Conversation
Part of petercorke#677 (examples folder rationalization). - icra2021.py, mexican-wave.py: update to the current ET/Robot/xplot/ iscollided API. - Remove fetch_vision.py (FetchCamera gone since petercorke#545), ikine_evaluate2.py (ikine_min never existed), and test.py (scratch file). - Add examples/README.md indexing every script with its required extras.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 143 143
Lines 14097 14097
=====================================
Misses 14097 14097 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #677 (examples folder rationalization).
icra2021.py,mexican-wave.py: update to the currentET/Robot/xplot/iscollidedAPI.fetch_vision.py(FetchCamerawas removed in fix(models): remove FetchCamera, unshippable and unused in RVC3 #545),ikine_evaluate2.py(ikine_minno longer exists, see fix(examples,dhrobot): repair broken ikine_LMS/ikine_min example references #650) andtest.py(scratch file).examples/README.mdlisting every script with the extras it needs.Not done here, for your call: merging near-duplicate scripts (
RRMC/RRMC_swift,park/baur,mmc/swift_recording), andholistic_mm_non_holonomic.py, which needs a Frankie model with a mobile base to run again.Related issue
Part of #677.
Checklist
examples/*.pycompile