Skip to content

Handle P4.run argument conversion errors - #20

Open
kristjanvalur wants to merge 4 commits into
perforce:masterfrom
kristjanvalur:p4-run-argument-errors
Open

kristjanvalur wants to merge 4 commits into
perforce:masterfrom
kristjanvalur:p4-run-argument-errors

Conversation

@kristjanvalur

@kristjanvalur kristjanvalur commented Nov 14, 2026 •

Copy link
Copy Markdown

Summary

  • Propagate command and argument conversion failures and release temporary Python objects.
  • Check the argument count before narrowing to C int.
  • Add focused argument-conversion tests.

Validation

  • Built the extension and ran testRunArgumentConversionErrors, testInfo and testUnicode.
  • The actual INT_MAX argument-count boundary was not exercised.

@kristjanvalur
kristjanvalur marked this pull request as ready for review November 14, 2026 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant