Skip to content

Guard adapter attributes and conversion sizes - #14

Open
kristjanvalur wants to merge 3 commits into
perforce:masterfrom
kristjanvalur:adapter-attribute-bounds
Open

kristjanvalur wants to merge 3 commits into
perforce:masterfrom
kristjanvalur:adapter-attribute-bounds

Conversation

@kristjanvalur

@kristjanvalur kristjanvalur commented Nov 14, 2026 •

Copy link
Copy Markdown

Summary

  • Reject unsupported attribute deletion and propagate attribute conversion errors.
  • Check Python integer values and charset conversion lengths before narrowing to C int.
  • Add tests for attribute bounds, failure cases and embedded NUL conversion.

Validation

  • Built the extension and ran focused attribute, conversion, argument and environment tests.
  • Oversized content at the actual INT_MAX boundary was not exercised.

kristjanvalur and others added 3 commits November 14, 2026 18:05
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kristjanvalur
kristjanvalur marked this pull request as ready for review November 14, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant